Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat port: Logic.Equiv.Set #1044

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat port: Logic.Equiv.Set #1044

wants to merge 7 commits into from

Conversation

ChrisHughes24
Copy link
Member

aba57d4d3dae35460225919dcd82fe91355162f9

@ChrisHughes24 ChrisHughes24 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Dec 15, 2022
@ChrisHughes24 ChrisHughes24 added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. and removed mathlib-port This is a port of a theory file from mathlib. WIP Work in progress labels Dec 15, 2022
j-loreaux
j-loreaux approved these changes Dec 15, 2022
View reviewed changes
Copy link
Collaborator

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. All these changes are very minor.

Mathlib/Logic/Equiv/Set.lean Outdated Show resolved Hide resolved
Mathlib/Logic/Equiv/Set.lean Outdated Show resolved Hide resolved
Mathlib/Logic/Equiv/Set.lean Outdated Show resolved Hide resolved
Mathlib/Logic/Equiv/Set.lean Outdated Show resolved Hide resolved
Mathlib/Logic/Equiv/Set.lean Outdated Show resolved Hide resolved
Mathlib/Logic/Equiv/Set.lean Outdated Show resolved Hide resolved
Mathlib/Logic/Equiv/Set.lean Outdated Show resolved Hide resolved
Mathlib/Logic/Equiv/Set.lean Outdated Show resolved Hide resolved
Mathlib/Logic/Equiv/Set.lean Outdated Show resolved Hide resolved
Mathlib/Logic/Equiv/Set.lean Outdated Show resolved Hide resolved
@dupuisf
Copy link
Contributor

dupuisf commented Dec 15, 2022

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 15, 2022
bors bot pushed a commit that referenced this pull request Dec 15, 2022
@ChrisHughes24 @j-loreaux
feat port: Logic.Equiv.Set (#1044)
7495fe3 
aba57d4d3dae35460225919dcd82fe91355162f9

Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
@bors
Copy link

bors bot commented Dec 15, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat port: Logic.Equiv.Set [Merged by Bors] - feat port: Logic.Equiv.Set Dec 15, 2022
@bors bors bot closed this Dec 15, 2022
@bors bors bot deleted the Logic.Equiv.Set branch December 15, 2022 18:12
@github-actions github-actions bot mentioned this pull request Dec 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-loreaux j-loreaux j-loreaux approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChrisHughes24 @dupuisf @j-loreaux