Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: the pairing of a Lie algebra root space with its negative #10454

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat: the pairing of a Lie algebra root space with its negative #10454

wants to merge 4 commits into from

Conversation

ocfnash
Copy link
Contributor

@ocfnash ocfnash commented Feb 12, 2024

Open in Gitpod

@ocfnash ocfnash added awaiting-review The author would like community review of the PR awaiting-CI t-algebra Algebra (groups, rings, fields etc) labels Feb 12, 2024
@jcommelin jcommelin self-assigned this Feb 12, 2024
jcommelin
jcommelin reviewed Feb 12, 2024
View reviewed changes
Mathlib/Logic/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Lie/Weights/Cartan.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 12, 2024
ocfnash and others added 3 commits February 12, 2024 15:50
@ocfnash @jcommelin
Update Mathlib/Logic/Basic.lean
8e9bccb 
Co-authored-by: Johan Commelin <johan@commelin.net>
@ocfnash @jcommelin
Update Mathlib/Algebra/Lie/Weights/Cartan.lean
d88b4ac 
Co-authored-by: Johan Commelin <johan@commelin.net>
@ocfnash
Fix after rename in suggestion
b3ee2a0
@ocfnash ocfnash added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 12, 2024
jcommelin
jcommelin approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 12, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 12, 2024
@ocfnash
feat: the pairing of a Lie algebra root space with its negative (#10454)
64edf01
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 12, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: the pairing of a Lie algebra root space with its negative [Merged by Bors] - feat: the pairing of a Lie algebra root space with its negative Feb 12, 2024
@mathlib-bors mathlib-bors bot closed this Feb 12, 2024
@mathlib-bors mathlib-bors bot deleted the ocfnash/lie_coroot_span branch February 12, 2024 18:32
@ocfnash ocfnash mentioned this pull request Feb 23, 2024
Open
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@ocfnash @dagurtomas
feat: the pairing of a Lie algebra root space with its negative (#10454)
960bfb6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees

@jcommelin jcommelin

Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ocfnash @jcommelin @leanprover-community-mathlib4-bot