Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(FinsuppVectorSpace): golf, Fintype -> Finite #10464

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(FinsuppVectorSpace): golf, Fintype -> Finite #10464

wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 12, 2024

  • Golf Finset.sum_single_ite. Should it go to another file?
  • Assume Finite instead of Fintype in equivFun_symm_stdBasis.

Open in Gitpod

@urkud
chore(FinsuppVectorSpace): golf, Fintype -> Finite
bd788c3 
- Golf `Finset.sum_single_ite`. Should it go to another file?
- Assume `Finite` instead of `Fintype` in `equivFun_symm_stdBasis`.
@urkud urkud added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Feb 12, 2024
jcommelin
jcommelin approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 13, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 13, 2024
@urkud
chore(FinsuppVectorSpace): golf, Fintype -> Finite (#10464)
a8eca77 
- Golf `Finset.sum_single_ite`. Should it go to another file?
- Assume `Finite` instead of `Fintype` in `equivFun_symm_stdBasis`.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 13, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(FinsuppVectorSpace): golf, Fintype -> Finite [Merged by Bors] - chore(FinsuppVectorSpace): golf, Fintype -> Finite Feb 13, 2024
@mathlib-bors mathlib-bors bot closed this Feb 13, 2024
@mathlib-bors mathlib-bors bot deleted the YK-linalg-finsupp-vs branch February 13, 2024 14:05
riccardobrasca pushed a commit that referenced this pull request Feb 18, 2024
@urkud @riccardobrasca
chore(FinsuppVectorSpace): golf, Fintype -> Finite (#10464)
006257e 
- Golf `Finset.sum_single_ite`. Should it go to another file?
- Assume `Finite` instead of `Fintype` in `equivFun_symm_stdBasis`.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@urkud @dagurtomas
chore(FinsuppVectorSpace): golf, Fintype -> Finite (#10464)
cbff1b6 
- Golf `Finset.sum_single_ite`. Should it go to another file?
- Assume `Finite` instead of `Fintype` in `equivFun_symm_stdBasis`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @jcommelin @leanprover-community-mathlib4-bot