Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Add Finset.card_union_eq_card_add_card and golf #10471

Closed
wants to merge 3 commits into from

Conversation

acmepjz
Copy link
Collaborator

@acmepjz acmepjz commented Feb 13, 2024


Follows #10224

Open in Gitpod

@acmepjz acmepjz added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI and removed easy < 20s of review time. See the lifecycle page for guidelines. labels Feb 13, 2024
@acmepjz acmepjz changed the title add Finset.card_union_eq_iff and golf feat(Data/Finset/Card): add Finset.card_union_eq_iff and golf Feb 13, 2024
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@YaelDillies YaelDillies changed the title feat(Data/Finset/Card): add Finset.card_union_eq_iff and golf feat: Add Finset.card_union_eq_card_add_card and golf Feb 13, 2024
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 13, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 13, 2024
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 13, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Feb 13, 2024
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 13, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Feb 13, 2024
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@acmepjz
Copy link
Collaborator Author

acmepjz commented Feb 13, 2024

There are compile errors, but seems not related to this PR.

@mathlib-bors
Copy link

mathlib-bors bot commented Feb 13, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Add Finset.card_union_eq_card_add_card and golf [Merged by Bors] - feat: Add Finset.card_union_eq_card_add_card and golf Feb 13, 2024
@mathlib-bors mathlib-bors bot closed this Feb 13, 2024
@mathlib-bors mathlib-bors bot deleted the acmepjz_card_union_eq_iff branch February 13, 2024 11:56
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants