Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: avoid non-terminal simps and golf proofs #10486

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore: avoid non-terminal simps and golf proofs #10486

wants to merge 2 commits into from

Conversation

chabulhwi
Copy link
Collaborator

@chabulhwi chabulhwi commented Feb 13, 2024 •
edited

  • Replace non-terminal simps with simp onlys.
  • Golf proofs.

Open in Gitpod

@chabulhwi chabulhwi self-assigned this Feb 13, 2024
@chabulhwi chabulhwi added the awaiting-review The author would like community review of the PR label Feb 13, 2024
jcommelin
jcommelin approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 13, 2024
@chabulhwi chabulhwi changed the title chore: golf proofs and avoid non-terminal simps chore: avoid non-terminal simps and golf proofs Feb 13, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 13, 2024
@chabulhwi
chore: avoid non-terminal simps and golf proofs (#10486)
ab35bb3 
* Replace non-terminal `simp`s with `simp only`s.
* Golf proofs.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 13, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: avoid non-terminal simps and golf proofs [Merged by Bors] - chore: avoid non-terminal simps and golf proofs Feb 13, 2024
@mathlib-bors mathlib-bors bot closed this Feb 13, 2024
@mathlib-bors mathlib-bors bot deleted the BC_fix_proofs branch February 13, 2024 14:05
riccardobrasca pushed a commit that referenced this pull request Feb 18, 2024
@chabulhwi @riccardobrasca
chore: avoid non-terminal simps and golf proofs (#10486)
2fc7d8c 
* Replace non-terminal `simp`s with `simp only`s.
* Golf proofs.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@chabulhwi @dagurtomas
chore: avoid non-terminal simps and golf proofs (#10486)
5c594f4 
* Replace non-terminal `simp`s with `simp only`s.
* Golf proofs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees

@chabulhwi chabulhwi

Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chabulhwi @jcommelin @leanprover-community-mathlib4-bot