Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: the absolute discriminant of cyclotomic fields #10492

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: the absolute discriminant of cyclotomic fields #10492

wants to merge 7 commits into from

Conversation

riccardobrasca
Copy link
Member

@riccardobrasca riccardobrasca commented Feb 13, 2024 •
edited

We compute the absolute discriminant of cyclotomic fields.

From flt-regular.

Open in Gitpod

@riccardobrasca riccardobrasca added WIP Work in progress t-number-theory Number theory (also use t-algebra or t-analysis to specialize) t-algebra Algebra (groups, rings, fields etc) labels Feb 13, 2024
@riccardobrasca riccardobrasca added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Feb 13, 2024
@riccardobrasca @alexjbest
Update Mathlib/NumberTheory/Cyclotomic/Rat.lean
0586931 
Co-authored-by: Alex J Best <alex.j.best@gmail.com>
@riccardobrasca riccardobrasca mentioned this pull request Feb 14, 2024
Closed
2 tasks
@alexjbest
Copy link
Member

LGTM

maintainer merge

@github-actions GitHub Actions
Copy link

🚀 Pull request has been placed on the maintainer queue by alexjbest.

jcommelin
jcommelin approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 15, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 15, 2024
@riccardobrasca
feat: the absolute discriminant of cyclotomic fields (#10492)
60c811a 
We compute the absolute discriminant of cyclotomic fields.


From flt-regular.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 15, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: the absolute discriminant of cyclotomic fields [Merged by Bors] - feat: the absolute discriminant of cyclotomic fields Feb 15, 2024
@mathlib-bors mathlib-bors bot closed this Feb 15, 2024
@mathlib-bors mathlib-bors bot deleted the RB/abs_discr branch February 15, 2024 21:52
riccardobrasca added a commit that referenced this pull request Feb 18, 2024
@riccardobrasca
feat: the absolute discriminant of cyclotomic fields (#10492)
c97295b 
We compute the absolute discriminant of cyclotomic fields.


From flt-regular.
This was referenced Feb 18, 2024
Closed
Closed
mathlib-bors bot pushed a commit that referenced this pull request Mar 4, 2024
@riccardobrasca
feat: the ring of integers of the p-th cyclotomic field is a PID if p…
5f834b3 
… = 3 or p = 5 (#10683)

We prove that the ring of integers of the p-th cyclotomic field is a PID if p = 3 or p = 5.

From flt-regular

- [x] depends on: #10492 
- [x] depends on: #10502
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
@riccardobrasca @kbuzzard
feat: the ring of integers of the p-th cyclotomic field is a PID if p…
c3a7f33 
… = 3 or p = 5 (#10683)

We prove that the ring of integers of the p-th cyclotomic field is a PID if p = 3 or p = 5.

From flt-regular

- [x] depends on: #10492 
- [x] depends on: #10502
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@riccardobrasca @dagurtomas
feat: the absolute discriminant of cyclotomic fields (#10492)
954582f 
We compute the absolute discriminant of cyclotomic fields.


From flt-regular.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@riccardobrasca @dagurtomas
feat: the ring of integers of the p-th cyclotomic field is a PID if p…
6d32016 
… = 3 or p = 5 (#10683)

We prove that the ring of integers of the p-th cyclotomic field is a PID if p = 3 or p = 5.

From flt-regular

- [x] depends on: #10492 
- [x] depends on: #10502
utensil pushed a commit that referenced this pull request Mar 26, 2024
@riccardobrasca @utensil
feat: the ring of integers of the p-th cyclotomic field is a PID if p…
9c7d843 
… = 3 or p = 5 (#10683)

We prove that the ring of integers of the p-th cyclotomic field is a PID if p = 3 or p = 5.

From flt-regular

- [x] depends on: #10492 
- [x] depends on: #10502
Louddy pushed a commit that referenced this pull request Apr 15, 2024
@riccardobrasca @Louddy
feat: the ring of integers of the p-th cyclotomic field is a PID if p…
f34cf3b 
… = 3 or p = 5 (#10683)

We prove that the ring of integers of the p-th cyclotomic field is a PID if p = 3 or p = 5.

From flt-regular

- [x] depends on: #10492 
- [x] depends on: #10502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjbest alexjbest alexjbest left review comments

@jcommelin jcommelin jcommelin approved these changes

@xroblot xroblot xroblot approved these changes

Assignees
No one assigned
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc) t-number-theory Number theory (also use t-algebra or t-analysis to specialize)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@riccardobrasca @alexjbest @jcommelin @xroblot @leanprover-community-mathlib4-bot