New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: DecidableEq
for Multiset.ToType
#10505
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also clean up some of the documentation, for instance removing the claim that you shouldn't use `Multiset.ToType` directly.
LGTM |
madvorak
reviewed
Feb 13, 2024
eric-wieser
reviewed
Feb 14, 2024
jcommelin
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
Feb 14, 2024
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
kmill
added
awaiting-review
The author would like community review of the PR
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Feb 14, 2024
eric-wieser
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
Thanks!
leanprover-community-mathlib4-bot
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
The author would like community review of the PR
labels
Feb 14, 2024
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 14, 2024
Also clean up some of the documentation, for instance removing the claim that you shouldn't use `Multiset.ToType` directly.
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
feat:
[Merged by Bors] - feat: Feb 14, 2024
DecidableEq
for Multiset.ToType
DecidableEq
for Multiset.ToType
riccardobrasca
pushed a commit
that referenced
this pull request
Feb 18, 2024
Also clean up some of the documentation, for instance removing the claim that you shouldn't use `Multiset.ToType` directly.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
Also clean up some of the documentation, for instance removing the claim that you shouldn't use `Multiset.ToType` directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also clean up some of the documentation, for instance removing the claim that you shouldn't use
Multiset.ToType
directly.