Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: DecidableEq for Multiset.ToType #10505

Closed
wants to merge 2 commits into from

Conversation

kmill
Copy link
Contributor

@kmill kmill commented Feb 13, 2024

Also clean up some of the documentation, for instance removing the claim that you shouldn't use Multiset.ToType directly.


Open in Gitpod

Also clean up some of the documentation, for instance removing the claim that you shouldn't use `Multiset.ToType` directly.
@kmill kmill added the awaiting-review The author would like community review of the PR label Feb 13, 2024
@madvorak
Copy link
Collaborator

LGTM

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 14, 2024
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@kmill kmill added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 14, 2024
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks!

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 14, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 14, 2024
Also clean up some of the documentation, for instance removing the claim that you shouldn't use `Multiset.ToType` directly.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 14, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: DecidableEq for Multiset.ToType [Merged by Bors] - feat: DecidableEq for Multiset.ToType Feb 14, 2024
@mathlib-bors mathlib-bors bot closed this Feb 14, 2024
@mathlib-bors mathlib-bors bot deleted the kmill_multiset_totype_deceq branch February 14, 2024 10:22
riccardobrasca pushed a commit that referenced this pull request Feb 18, 2024
Also clean up some of the documentation, for instance removing the claim that you shouldn't use `Multiset.ToType` directly.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
Also clean up some of the documentation, for instance removing the claim that you shouldn't use `Multiset.ToType` directly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants