Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: add Submodule.Quotient.instBoundedSMul #10520

Closed
wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Member

The proof needs minimal modifications to go through for the inequality case.


Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. t-analysis Analysis (normed *, calculus) labels Feb 14, 2024
Copy link
Collaborator

@adomani adomani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Should it be !benched? I always wonder about possible performance issues of instances...

@mcdoll
Copy link
Member

mcdoll commented Feb 14, 2024

I don't think that performance should be an issue here.
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by mcdoll.

@urkud urkud changed the title feat: add Submodule.instBoundedSMul feat: add Submodule.Quotient.instBoundedSMul Feb 14, 2024
@urkud
Copy link
Member

urkud commented Feb 14, 2024

Thanks! 🎉
bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 14, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 14, 2024
The proof needs minimal modifications to go through for the inequality case.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 14, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: add Submodule.Quotient.instBoundedSMul [Merged by Bors] - feat: add Submodule.Quotient.instBoundedSMul Feb 14, 2024
@mathlib-bors mathlib-bors bot closed this Feb 14, 2024
@mathlib-bors mathlib-bors bot deleted the eric-wieser/quotient-boundedSMul branch February 14, 2024 05:26
riccardobrasca pushed a commit that referenced this pull request Feb 18, 2024
The proof needs minimal modifications to go through for the inequality case.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
The proof needs minimal modifications to go through for the inequality case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants