Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(Set/Finite): redefine using _root_.Finite #10542

Closed
wants to merge 23 commits into from
Closed

[Merged by Bors] - refactor(Set/Finite): redefine using _root_.Finite #10542

wants to merge 23 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 14, 2024

Open in Gitpod

urkud and others added 23 commits January 18, 2024 01:55
@urkud
refactor(Set/Countable): redefine Set.Countable
8bd326d 
Turn `Set.Countable s` into an abbreviation for `_root_.Countable s`,
fix compile.
@urkud
Fix
cc5b87f
@urkud
Fix lint
be96713
@urkud @sgouezel
Update Mathlib/Data/Set/Countable.lean
b609431 
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@urkud
Merge branch 'master' into YK-set-countable
5581470
@urkud
Partially revert, use def instead of abbrev
863568c
@urkud
Fix
2156a21
@urkud
Fix
7946b01
@urkud
Fix
f51c3a9
@urkud
Merge branch 'master' into YK-set-countable
c03876f
@urkud
Def
215bc65
@urkud
Merge branch 'master' into YK-set-countable
35753e6
@urkud
Drop `an abbreviation for'
f953f61
@urkud
Merge branch 'YK-set-countable' into YK-set-finite
0371dac
@urkud
Start fixing
2b511ba
@urkud
Merge master into YK-set-finite (using imerge)
ab4aeca
@urkud
Fix a file
afd4d66
@urkud
Fix 3 files
e464842
@urkud
Merge branch 'master' into YK-set-finite
624cfdd
@urkud
Fix 2 files
820e6a2
@urkud
Fix a file
9ab9658
@urkud
Merge branch 'master' into YK-set-finite
691eba7
@urkud
Update docs
8050353
@urkud urkud added awaiting-review The author would like community review of the PR t-logic Logic (model theory, set theory, etc) labels Feb 14, 2024
jcommelin
jcommelin approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 15, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 15, 2024
@urkud
refactor(Set/Finite): redefine using _root_.Finite (#10542)
a39f83f
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 15, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(Set/Finite): redefine using _root_.Finite [Merged by Bors] - refactor(Set/Finite): redefine using _root_.Finite Feb 15, 2024
@mathlib-bors mathlib-bors bot closed this Feb 15, 2024
@mathlib-bors mathlib-bors bot deleted the YK-set-finite branch February 15, 2024 21:13
riccardobrasca pushed a commit that referenced this pull request Feb 18, 2024
@urkud @riccardobrasca
refactor(Set/Finite): redefine using _root_.Finite (#10542)
8c3207f
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@urkud @dagurtomas
refactor(Set/Finite): redefine using _root_.Finite (#10542)
d540280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-logic Logic (model theory, set theory, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @jcommelin @leanprover-community-mathlib4-bot