Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Topology/Order): golf, deprecate #10554

Closed
wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 14, 2024

  • golf atBot_le_nhds_bot and atTop_le_nhds_top;
  • deprecate them;
  • use tendsto_atTop_iInf instead in CondCdf.

Open in Gitpod

- golf `atBot_le_nhds_bot` and `atTop_le_nhds_top`;
- deprecate them;
- use `tendsto_atTop_iInf` instead in `CondCdf`.
@urkud urkud added awaiting-review The author would like community review of the PR t-topology Topological spaces, uniform spaces, metric spaces, filters t-order Order hierarchy labels Feb 14, 2024
@urkud
Copy link
Member Author

urkud commented Feb 14, 2024

@RemyDegenne you added these lemmas. Are you OK with me deprecating them?

@RemyDegenne
Copy link
Contributor

You could also simply delete them. I don't think they are used anywhere else. Their existence seems to be purely due to me not finding the right lemma.

@RemyDegenne
Copy link
Contributor

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Feb 14, 2024

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Feb 14, 2024
@urkud
Copy link
Member Author

urkud commented Feb 14, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Feb 14, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 14, 2024
- golf `atBot_le_nhds_bot` and `atTop_le_nhds_top`;
- deprecate them;
- use `tendsto_atTop_iInf` instead in `CondCdf`.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 15, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Topology/Order): golf, deprecate [Merged by Bors] - chore(Topology/Order): golf, deprecate Feb 15, 2024
@mathlib-bors mathlib-bors bot closed this Feb 15, 2024
@mathlib-bors mathlib-bors bot deleted the YK-nhds-bot branch February 15, 2024 00:39
riccardobrasca pushed a commit that referenced this pull request Feb 18, 2024
- golf `atBot_le_nhds_bot` and `atTop_le_nhds_top`;
- deprecate them;
- use `tendsto_atTop_iInf` instead in `CondCdf`.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
- golf `atBot_le_nhds_bot` and `atTop_le_nhds_top`;
- deprecate them;
- use `tendsto_atTop_iInf` instead in `CondCdf`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-order Order hierarchy t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants