Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: Port GroupTheory.GroupAction.Prod #1056

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: Port GroupTheory.GroupAction.Prod #1056

wants to merge 5 commits into from

Conversation

adamtopaz
Copy link
Contributor

mathlib3 SHA: aba57d4d3dae35460225919dcd82fe91355162f9

@adamtopaz adamtopaz added the awaiting-review The author would like community review of the PR label Dec 15, 2022
@adamtopaz adamtopaz added the mathlib-port This is a port of a theory file from mathlib. label Dec 15, 2022
@semorrison
Copy link
Contributor

bors d+

Please change Yes to No on the port status wiki page when you merge.

@bors
Copy link

bors bot commented Dec 16, 2022

✌️ adamtopaz can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Dec 16, 2022
@adamtopaz @semorrison
Apply suggestions from code review
59f1833 
Co-authored-by: Scott Morrison <scott@tqft.net>
@adamtopaz
Copy link
Contributor Author

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Dec 16, 2022
bors bot pushed a commit that referenced this pull request Dec 16, 2022
@adamtopaz
feat: Port GroupTheory.GroupAction.Prod (#1056)
07ab3cf 
mathlib3 SHA: aba57d4d3dae35460225919dcd82fe91355162f9

Co-authored-by: Adam Topaz <adamtopaz@users.noreply.github.com>
@bors
Copy link

bors bot commented Dec 16, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: Port GroupTheory.GroupAction.Prod [Merged by Bors] - feat: Port GroupTheory.GroupAction.Prod Dec 16, 2022
@bors bors bot closed this Dec 16, 2022
@bors bors bot deleted the GroupAction-Prod branch December 16, 2022 12:00
@fpvandoorn fpvandoorn mentioned this pull request Dec 16, 2022
Open
7 tasks
@github-actions github-actions bot mentioned this pull request Dec 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamtopaz @semorrison