[Merged by Bors] - chore(Topology/OrderClosed): review API #10570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Generalize lemmas from `OrderClosedTopology` to `ClosedIciTopology` or `ClosedIicTopology`. - Deprecate `isClosed_le'`/`isClosed_ge'`, use more readable `isClosed_Iic`/`isClosed_Ici` instead.
urkud
added
awaiting-review
1 task
|
Could you add deprecation statements for |
sgouezel
added
awaiting-author
|
@sgouezel Done. |
urkud
added
awaiting-review
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
- Generalize lemmas from `OrderClosedTopology` to `ClosedIciTopology` or `ClosedIicTopology`. - Deprecate `isClosed_le'`/`isClosed_ge'`, use more readable `isClosed_Iic`/`isClosed_Ici` instead.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
riccardobrasca
pushed a commit
that referenced
this pull request
Feb 18, 2024
- Generalize lemmas from `OrderClosedTopology` to `ClosedIciTopology` or `ClosedIicTopology`. - Deprecate `isClosed_le'`/`isClosed_ge'`, use more readable `isClosed_Iic`/`isClosed_Ici` instead.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
- Generalize lemmas from `OrderClosedTopology` to `ClosedIciTopology` or `ClosedIicTopology`. - Deprecate `isClosed_le'`/`isClosed_ge'`, use more readable `isClosed_Iic`/`isClosed_Ici` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OrderClosedTopologyto
ClosedIciTopologyorClosedIicTopology.isClosed_le'/isClosed_ge',use more readable
isClosed_Iic/isClosed_Iciinstead.