Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: add some simple results regarding polynomials #10572

Closed
wants to merge 1 commit into from

Conversation

acmepjz
Copy link
Collaborator

@acmepjz acmepjz commented Feb 15, 2024

  • Polynomial.map_contract: Polynomial.map and Polynomial.contract commutes
  • Irreducible.natDegree_pos: an irreducible polynomial over a field must have positive degree (not true if it's not a field)
  • Polynomial.Monic.nextCoeff_pow: corollary of Polynomial.Monic.nextCoeff_mul
  • Polynomial.exists_monic_irreducible_factor: a polynomial over a field which is not a unit must have a monic irreducible factor (not true if it's not a field)

Open in Gitpod

@acmepjz acmepjz added awaiting-review The author would like community review of the PR awaiting-CI t-algebra Algebra (groups, rings, fields etc) labels Feb 15, 2024
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 15, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 15, 2024
- `Polynomial.map_contract`: `Polynomial.map` and `Polynomial.contract` commutes
- `Irreducible.natDegree_pos`: an irreducible polynomial over a field must have positive degree (not true if it's not a field)
- `Polynomial.Monic.nextCoeff_pow`: corollary of `Polynomial.Monic.nextCoeff_mul`
- `Polynomial.exists_monic_irreducible_factor`: a polynomial over a field which is not a unit must have a monic irreducible factor (not true if it's not a field)
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 15, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: add some simple results regarding polynomials [Merged by Bors] - feat: add some simple results regarding polynomials Feb 15, 2024
@mathlib-bors mathlib-bors bot closed this Feb 15, 2024
@mathlib-bors mathlib-bors bot deleted the acmepjz_polynomial_result_1 branch February 15, 2024 17:31
riccardobrasca pushed a commit that referenced this pull request Feb 18, 2024
- `Polynomial.map_contract`: `Polynomial.map` and `Polynomial.contract` commutes
- `Irreducible.natDegree_pos`: an irreducible polynomial over a field must have positive degree (not true if it's not a field)
- `Polynomial.Monic.nextCoeff_pow`: corollary of `Polynomial.Monic.nextCoeff_mul`
- `Polynomial.exists_monic_irreducible_factor`: a polynomial over a field which is not a unit must have a monic irreducible factor (not true if it's not a field)
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
- `Polynomial.map_contract`: `Polynomial.map` and `Polynomial.contract` commutes
- `Irreducible.natDegree_pos`: an irreducible polynomial over a field must have positive degree (not true if it's not a field)
- `Polynomial.Monic.nextCoeff_pow`: corollary of `Polynomial.Monic.nextCoeff_mul`
- `Polynomial.exists_monic_irreducible_factor`: a polynomial over a field which is not a unit must have a monic irreducible factor (not true if it's not a field)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants