[Merged by Bors] - feat: Add mul_inv and inv_mul versions of div_le_one_of_le
#10597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girving
added
awaiting-review
1 task
|
Possibly I should add |
|
Yes, and iff versions assuming |
girving
changed the title
mul_inv_le_one_of_le is an a * b⁻¹ div_le_one_of_lemul_inv_le_one_of_le is an a * b⁻¹ version of div_le_one_of_le
girving
changed the title
mul_inv_le_one_of_le is an a * b⁻¹ version of div_le_one_of_lemul_inv and inv_mul versions of div_le_one_of_le
|
Now that's better! |
|
@YaelDillies: Would you be up for a review and approval if it seems reasonable? |
YaelDillies
reviewed
Feb 20, 2024
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
YaelDillies
approved these changes
Feb 20, 2024
|
What’s the next step after “maintainer merge”? |
|
Nothing on your part. A maintainer will merge the PR or come up with a comment I hadn't thought of. |
|
Thanks! 🎉 |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
) These are exactly `div_le_one_of_le` with `a / b` replaced by `a * b⁻¹` and `b⁻¹ * a`. They come up frequently because some tactics produce inverses as normal forms over division. The iff versions with `0 < b` already exist as `mul_inv_le_one_iff` and `inv_mul_le_one_iff`; the point of these is to have a weaker nonnegativity assumption on `b`.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
mul_inv and inv_mul versions of div_le_one_of_lemul_inv and inv_mul versions of div_le_one_of_le
thorimur
pushed a commit
that referenced
this pull request
Feb 24, 2024
) These are exactly `div_le_one_of_le` with `a / b` replaced by `a * b⁻¹` and `b⁻¹ * a`. They come up frequently because some tactics produce inverses as normal forms over division. The iff versions with `0 < b` already exist as `mul_inv_le_one_iff` and `inv_mul_le_one_iff`; the point of these is to have a weaker nonnegativity assumption on `b`.
thorimur
pushed a commit
that referenced
this pull request
Feb 26, 2024
) These are exactly `div_le_one_of_le` with `a / b` replaced by `a * b⁻¹` and `b⁻¹ * a`. They come up frequently because some tactics produce inverses as normal forms over division. The iff versions with `0 < b` already exist as `mul_inv_le_one_iff` and `inv_mul_le_one_iff`; the point of these is to have a weaker nonnegativity assumption on `b`.
riccardobrasca
pushed a commit
that referenced
this pull request
Mar 1, 2024
) These are exactly `div_le_one_of_le` with `a / b` replaced by `a * b⁻¹` and `b⁻¹ * a`. They come up frequently because some tactics produce inverses as normal forms over division. The iff versions with `0 < b` already exist as `mul_inv_le_one_iff` and `inv_mul_le_one_iff`; the point of these is to have a weaker nonnegativity assumption on `b`.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
) These are exactly `div_le_one_of_le` with `a / b` replaced by `a * b⁻¹` and `b⁻¹ * a`. They come up frequently because some tactics produce inverses as normal forms over division. The iff versions with `0 < b` already exist as `mul_inv_le_one_iff` and `inv_mul_le_one_iff`; the point of these is to have a weaker nonnegativity assumption on `b`.
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
) These are exactly `div_le_one_of_le` with `a / b` replaced by `a * b⁻¹` and `b⁻¹ * a`. They come up frequently because some tactics produce inverses as normal forms over division. The iff versions with `0 < b` already exist as `mul_inv_le_one_iff` and `inv_mul_le_one_iff`; the point of these is to have a weaker nonnegativity assumption on `b`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are exactly
div_le_one_of_lewitha / breplaced bya * b⁻¹andb⁻¹ * a.They come up frequently because some tactics produce inverses as normal forms over division. The iff versions with
0 < balready exist asmul_inv_le_one_iffandinv_mul_le_one_iff; the point of these is to have a weaker nonnegativity assumption onb.