Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: move BddBelow.finite_of_bddAbove to Order.LocallyFinite #10613

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore: move BddBelow.finite_of_bddAbove to Order.LocallyFinite #10613

wants to merge 2 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

Open in Gitpod

@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR awaiting-CI labels Feb 15, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 19, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 19, 2024
jcommelin
jcommelin approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 20, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 20, 2024
@Ruben-VandeVelde
chore: move BddBelow.finite_of_bddAbove to Order.LocallyFinite (#10613)
b82963a
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 20, 2024

Build failed (retrying...):

  • Build

mathlib-bors bot pushed a commit that referenced this pull request Feb 20, 2024
@Ruben-VandeVelde
chore: move BddBelow.finite_of_bddAbove to Order.LocallyFinite (#10613)
b255974
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 20, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: move BddBelow.finite_of_bddAbove to Order.LocallyFinite [Merged by Bors] - chore: move BddBelow.finite_of_bddAbove to Order.LocallyFinite Feb 20, 2024
@mathlib-bors mathlib-bors bot closed this Feb 20, 2024
@mathlib-bors mathlib-bors bot deleted the BddBelow.finite_of_bddAbove branch February 20, 2024 19:12
thorimur pushed a commit that referenced this pull request Feb 24, 2024
@Ruben-VandeVelde @thorimur
chore: move BddBelow.finite_of_bddAbove to Order.LocallyFinite (#10613)
0eb27d2
thorimur pushed a commit that referenced this pull request Feb 26, 2024
@Ruben-VandeVelde @thorimur
chore: move BddBelow.finite_of_bddAbove to Order.LocallyFinite (#10613)
4e53b89
riccardobrasca pushed a commit that referenced this pull request Mar 1, 2024
@Ruben-VandeVelde @riccardobrasca
chore: move BddBelow.finite_of_bddAbove to Order.LocallyFinite (#10613)
8045a1b
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@Ruben-VandeVelde @dagurtomas
chore: move BddBelow.finite_of_bddAbove to Order.LocallyFinite (#10613)
fcb5626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ruben-VandeVelde @jcommelin @leanprover-community-mathlib4-bot