[Merged by Bors] - bug (Mathlib.Data.Finset.Sym) : suppress global variable (m : Sym alpha n) #10637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoineChambert-Loir
added
the
easy
|
Thanks! And you get a bonus point for removing a porting note :-) |
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by kbuzzard. |
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
…ha n) (#10637) A global `variable {m : Sym α n}` was present in `Mathlib.Data.Finset.Sym` with the very unfortunate effect that docs#Finset.sym_eq_empty was using it : ``` theorem Finset.sym_eq_empty {α : Type u_1} [DecidableEq α] {s : Finset α} {n : ℕ} {m : Sym α n} : Finset.sym s n = ∅ ↔ n ≠ 0 ∧ s = ∅ ``` thus making it impossible to use to prove its goal. The line is modified, added in a few functions when needed. Co-authored-by: Antoine Chambert-Loir <antoine.chambert-loir@math.univ-paris-diderot.fr>
|
I assume leanprover/lean4#2452 would help here? |
AntoineChambert-Loir
added
awaiting-review
|
I suspect the problem comes from there, but I didn't try to understand what happened. |
|
Reading the file, it looks like |
|
Yes, with leanprover/lean4#2452 there would have been no issue here. |
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
riccardobrasca
pushed a commit
that referenced
this pull request
Feb 18, 2024
…ha n) (#10637) A global `variable {m : Sym α n}` was present in `Mathlib.Data.Finset.Sym` with the very unfortunate effect that docs#Finset.sym_eq_empty was using it : ``` theorem Finset.sym_eq_empty {α : Type u_1} [DecidableEq α] {s : Finset α} {n : ℕ} {m : Sym α n} : Finset.sym s n = ∅ ↔ n ≠ 0 ∧ s = ∅ ``` thus making it impossible to use to prove its goal. The line is modified, added in a few functions when needed. Co-authored-by: Antoine Chambert-Loir <antoine.chambert-loir@math.univ-paris-diderot.fr>
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
…ha n) (#10637) A global `variable {m : Sym α n}` was present in `Mathlib.Data.Finset.Sym` with the very unfortunate effect that docs#Finset.sym_eq_empty was using it : ``` theorem Finset.sym_eq_empty {α : Type u_1} [DecidableEq α] {s : Finset α} {n : ℕ} {m : Sym α n} : Finset.sym s n = ∅ ↔ n ≠ 0 ∧ s = ∅ ``` thus making it impossible to use to prove its goal. The line is modified, added in a few functions when needed. Co-authored-by: Antoine Chambert-Loir <antoine.chambert-loir@math.univ-paris-diderot.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A global
variable {m : Sym α n}was present inMathlib.Data.Finset.Symwith the very unfortunate effect that docs#Finset.sym_eq_empty was using it :thus making it impossible to use to prove its goal.
The line is modified, added in a few functions when needed.