Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: add monic_X_pow_add_C #10643

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat: add monic_X_pow_add_C #10643

wants to merge 2 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

Open in Gitpod

@Ruben-VandeVelde @negiizhao
feat: add monic_X_pow_add_C
2590a0c 
Co-authored-by: negiizhao <egresf@gmail.com>
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR awaiting-CI labels Feb 16, 2024
acmepjz
acmepjz approved these changes Feb 17, 2024
View reviewed changes
Copy link
Collaborator

@acmepjz acmepjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Could you use monic_X_pow_add_C to simplify the proof of monic_X_pow_sub_C?

@j-loreaux
Copy link
Collaborator

Thanks! Golf the proof of monic_X_pow_sub_C if you want.

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Feb 17, 2024

✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Feb 17, 2024
@Ruben-VandeVelde
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Feb 17, 2024
@Ruben-VandeVelde
feat: add monic_X_pow_add_C (#10643)
e58bf58
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 17, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: add monic_X_pow_add_C [Merged by Bors] - feat: add monic_X_pow_add_C Feb 17, 2024
@mathlib-bors mathlib-bors bot closed this Feb 17, 2024
@mathlib-bors mathlib-bors bot deleted the monic_X_pow_add_C branch February 17, 2024 21:19
riccardobrasca pushed a commit that referenced this pull request Feb 18, 2024
@Ruben-VandeVelde @riccardobrasca
feat: add monic_X_pow_add_C (#10643)
d8ffd7d
thorimur pushed a commit that referenced this pull request Feb 24, 2024
@Ruben-VandeVelde @thorimur
feat: add monic_X_pow_add_C (#10643)
1377c1d
thorimur pushed a commit that referenced this pull request Feb 26, 2024
@Ruben-VandeVelde @thorimur
feat: add monic_X_pow_add_C (#10643)
26104f0
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@Ruben-VandeVelde @dagurtomas
feat: add monic_X_pow_add_C (#10643)
517f5e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acmepjz acmepjz acmepjz approved these changes

Assignees
No one assigned
Labels
delegated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ruben-VandeVelde @j-loreaux @acmepjz