Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Data/Polynomial/RingDivision): eq_zero_of_forall_eval_zero_of_natDegree_lt_card #10656

Closed
wants to merge 1 commit into from

Conversation

jcommelin
Copy link
Member


Open in Gitpod

@jcommelin jcommelin added awaiting-review The author would like community review of the PR awaiting-CI labels Feb 17, 2024
@ocfnash
Copy link
Contributor

ocfnash commented Feb 18, 2024

My instinct is that we should have exactly one of the lemmas eq_zero_of_forall_eval_zero_of_natDegree_lt_card and its contrapositive exists_eval_ne_zero_of_natDegree_lt_card but I admit there are plenty of times when the convenience of such "contrapositive duplication" is worth it.

I'll let you make the call.

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Feb 18, 2024

✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Feb 18, 2024
@jcommelin
Copy link
Member Author

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Feb 19, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 19, 2024
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 19, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Data/Polynomial/RingDivision): eq_zero_of_forall_eval_zero_of_natDegree_lt_card [Merged by Bors] - feat(Data/Polynomial/RingDivision): eq_zero_of_forall_eval_zero_of_natDegree_lt_card Feb 19, 2024
@mathlib-bors mathlib-bors bot closed this Feb 19, 2024
@mathlib-bors mathlib-bors bot deleted the jmc-poly-funext-card branch February 19, 2024 08:33
riccardobrasca pushed a commit that referenced this pull request Feb 19, 2024
thorimur pushed a commit that referenced this pull request Feb 24, 2024
thorimur pushed a commit that referenced this pull request Feb 26, 2024
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants