Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(Data/Polynomial/Degree/TrailingDegree): some basic api lemmas #10657

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(Data/Polynomial/Degree/TrailingDegree): some basic api lemmas #10657

wants to merge 2 commits into from

Conversation

jcommelin
Copy link
Member

Open in Gitpod

@jcommelin jcommelin added awaiting-review The author would like community review of the PR awaiting-CI labels Feb 17, 2024
@j-loreaux
Copy link
Collaborator

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Feb 17, 2024

✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Feb 17, 2024
j-loreaux
j-loreaux reviewed Feb 17, 2024
View reviewed changes
Copy link
Collaborator

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, I meant to leave these before delegation.

Mathlib/Data/Polynomial/Degree/TrailingDegree.lean Outdated Show resolved Hide resolved
Mathlib/Data/Polynomial/Degree/TrailingDegree.lean Outdated Show resolved Hide resolved
@j-loreaux j-loreaux added the t-algebra Algebra (groups, rings, fields etc) label Feb 17, 2024
@jcommelin @j-loreaux @acmepjz
Apply suggestions from code review
489290a 
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Jz Pan <acme_pjz@hotmail.com>
@j-loreaux
Copy link
Collaborator

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Feb 17, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 17, 2024
@jcommelin
chore(Data/Polynomial/Degree/TrailingDegree): some basic api lemmas (#…
28bbcdd 
…10657)
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 17, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Data/Polynomial/Degree/TrailingDegree): some basic api lemmas [Merged by Bors] - chore(Data/Polynomial/Degree/TrailingDegree): some basic api lemmas Feb 17, 2024
@mathlib-bors mathlib-bors bot closed this Feb 17, 2024
@mathlib-bors mathlib-bors bot deleted the jmc-trailingNatDeg-lemmas branch February 17, 2024 23:07
riccardobrasca pushed a commit that referenced this pull request Feb 18, 2024
@jcommelin @riccardobrasca
chore(Data/Polynomial/Degree/TrailingDegree): some basic api lemmas (#…
6ae2994 
…10657)
thorimur pushed a commit that referenced this pull request Feb 24, 2024
@jcommelin @thorimur
chore(Data/Polynomial/Degree/TrailingDegree): some basic api lemmas (#…
1cb508a 
…10657)
thorimur pushed a commit that referenced this pull request Feb 26, 2024
@jcommelin @thorimur
chore(Data/Polynomial/Degree/TrailingDegree): some basic api lemmas (#…
5ad92c1 
…10657)
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@jcommelin @dagurtomas
chore(Data/Polynomial/Degree/TrailingDegree): some basic api lemmas (#…
955fe4f 
…10657)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acmepjz acmepjz acmepjz left review comments

@j-loreaux j-loreaux j-loreaux left review comments

Assignees
No one assigned
Labels
delegated ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcommelin @j-loreaux @acmepjz