Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: add issue number to instance was not necessary porting notes #10671

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore: add issue number to instance was not necessary porting notes #10671

wants to merge 1 commit into from

Conversation

pitmonticone
Copy link
Collaborator

@pitmonticone pitmonticone commented Feb 17, 2024 •
edited

Classifies by adding issue number (#10670) to porting notes claiming instance was not necessary.

@pitmonticone pitmonticone added awaiting-review The author would like community review of the PR porting-notes Mathlib3 to Mathlib4 porting notes. easy < 20s of review time. See the lifecycle page for guidelines. labels Feb 17, 2024
@eric-wieser
Copy link
Member

bors merge

Thanks!

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 17, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 17, 2024
@pitmonticone
chore: add issue number to instance was not necessary porting notes (…
dcfd3b1 
…#10671)

Adds issue number (#10670) to porting notes claiming `instance was not necessary`.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 17, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: add issue number to instance was not necessary porting notes [Merged by Bors] - chore: add issue number to instance was not necessary porting notes Feb 17, 2024
@mathlib-bors mathlib-bors bot closed this Feb 17, 2024
@mathlib-bors mathlib-bors bot deleted the pitmonticone/instance-was-not-necessary branch February 17, 2024 23:40
riccardobrasca pushed a commit that referenced this pull request Feb 18, 2024
@pitmonticone @riccardobrasca
chore: add issue number to instance was not necessary porting notes (…
1b529dd 
…#10671)

Adds issue number (#10670) to porting notes claiming `instance was not necessary`.
thorimur pushed a commit that referenced this pull request Feb 24, 2024
@pitmonticone @thorimur
chore: add issue number to instance was not necessary porting notes (…
971e80e 
…#10671)

Adds issue number (#10670) to porting notes claiming `instance was not necessary`.
thorimur pushed a commit that referenced this pull request Feb 26, 2024
@pitmonticone @thorimur
chore: add issue number to instance was not necessary porting notes (…
6eb52b7 
…#10671)

Adds issue number (#10670) to porting notes claiming `instance was not necessary`.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@pitmonticone @dagurtomas
chore: add issue number to instance was not necessary porting notes (…
5c6b5a4 
…#10671)

Adds issue number (#10670) to porting notes claiming `instance was not necessary`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. porting-notes Mathlib3 to Mathlib4 porting notes. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pitmonticone @eric-wieser