[Merged by Bors] - doc: Change old Lean 3 commands to Lean 4 in implementation notes #10707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarMohsenGit
changed the title
OmarMohsenGit
requested review from
ADedecker,
eric-wieser and
riccardobrasca
adomani
reviewed
Feb 19, 2024
adomani
added
the
awaiting-author
|
Taking into account Damiano's comment LGTM, thanks! bors d+ |
|
✌️ OmarMohsenGit can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: damiano <adomani@gmail.com>
ADedecker
removed
the
awaiting-author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
…0707) I changed Lean's 3 old "variables" command to Lean's 4 command "variable" in some implementation notes. I might have missed some Co-authored-by: Omar Mohsen <36500353+OmarMohsenGit@users.noreply.github.com>
|
Build failed: |
|
It seems like a random failure, let's try again. bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
…0707) I changed Lean's 3 old "variables" command to Lean's 4 command "variable" in some implementation notes. I might have missed some Co-authored-by: Omar Mohsen <36500353+OmarMohsenGit@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
thorimur
pushed a commit
that referenced
this pull request
Feb 24, 2024
…0707) I changed Lean's 3 old "variables" command to Lean's 4 command "variable" in some implementation notes. I might have missed some Co-authored-by: Omar Mohsen <36500353+OmarMohsenGit@users.noreply.github.com>
thorimur
pushed a commit
that referenced
this pull request
Feb 26, 2024
…0707) I changed Lean's 3 old "variables" command to Lean's 4 command "variable" in some implementation notes. I might have missed some Co-authored-by: Omar Mohsen <36500353+OmarMohsenGit@users.noreply.github.com>
riccardobrasca
pushed a commit
that referenced
this pull request
Mar 1, 2024
…0707) I changed Lean's 3 old "variables" command to Lean's 4 command "variable" in some implementation notes. I might have missed some Co-authored-by: Omar Mohsen <36500353+OmarMohsenGit@users.noreply.github.com>
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
…0707) I changed Lean's 3 old "variables" command to Lean's 4 command "variable" in some implementation notes. I might have missed some Co-authored-by: Omar Mohsen <36500353+OmarMohsenGit@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed Lean's 3 old "variables" command to Lean's 4 command "variable" in some implementation notes.
I might have missed some