Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: Remove Init.Propext #10709

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - chore: Remove Init.Propext #10709

wants to merge 7 commits into from

Conversation

YaelDillies
Copy link
Collaborator

These lemmas can easily go to Logic.Basic

Open in Gitpod

@YaelDillies
chore: Remove Init.Propext
3c50f70 
These lemmas can easily go to `Logic.Basic`
@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Feb 18, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 5, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 5, 2024
@YaelDillies YaelDillies added the easy < 20s of review time. See the lifecycle page for guidelines. label Mar 20, 2024
grunweg
grunweg approved these changes Mar 23, 2024
View reviewed changes
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible to me.

digama0
digama0 reviewed Apr 4, 2024
View reviewed changes
Mathlib/Logic/Basic.lean Outdated
Comment on lines 937 to 938
/-- Alias of `propext`. -/
lemma Iff.eq : (a ↔ b) → a = b := propext
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/-- Alias of `propext`. -/
lemma Iff.eq : (a ↔ b) → a = b := propext
alias Iff.eq := propext

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't because alias is not imported there. Should I import it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, it is? 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I remember the problem: alias creates def Iff.eq := propext, not lemma Iff.eq := propext. Will nolint for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it shouldn't? Report it as a bug if so

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's supposed to create defs from defs and theorems from theorems, but you are aliasing an axiom and I guess these can be either defs or theorems

jcommelin
jcommelin reviewed Apr 4, 2024
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Apr 4, 2024

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Apr 4, 2024
@YaelDillies
Copy link
Collaborator Author

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Apr 4, 2024
@YaelDillies
chore: Remove Init.Propext (#10709)
1d5ae61 
These lemmas can easily go to `Logic.Basic`
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 4, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: Remove Init.Propext [Merged by Bors] - chore: Remove Init.Propext Apr 4, 2024
@mathlib-bors mathlib-bors bot closed this Apr 4, 2024
@mathlib-bors mathlib-bors bot deleted the kill_init_propext branch April 4, 2024 17:55
Louddy pushed a commit that referenced this pull request Apr 15, 2024
@YaelDillies @Louddy
chore: Remove Init.Propext (#10709)
e31b9cc 
These lemmas can easily go to `Logic.Basic`
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
@YaelDillies @atarnoam
chore: Remove Init.Propext (#10709)
9a625f6 
These lemmas can easily go to `Logic.Basic`
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
@YaelDillies @uniwuni
chore: Remove Init.Propext (#10709)
f952153 
These lemmas can easily go to `Logic.Basic`
callesonne pushed a commit that referenced this pull request Apr 22, 2024
@YaelDillies @callesonne
chore: Remove Init.Propext (#10709)
07e8895 
These lemmas can easily go to `Logic.Basic`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digama0 digama0 digama0 left review comments

@jcommelin jcommelin jcommelin left review comments

@grunweg grunweg grunweg approved these changes

Assignees
No one assigned
Labels
delegated easy < 20s of review time. See the lifecycle page for guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@YaelDillies @digama0 @jcommelin @grunweg @leanprover-community-mathlib4-bot