Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: characterize roots of unity in cyclotomic extensions #10710

Closed
wants to merge 97 commits into from

Conversation

riccardobrasca
Copy link
Member

@riccardobrasca riccardobrasca commented Feb 18, 2024

We add IsPrimitiveRoot.exists_pow_or_neg_mul_pow_of_isOfFinOrder: If x is a root of unity (spelled as IsOfFinOrder x) in an n-th cyclotomic extension of , where n is odd, and ζ is a primitive n-th root of unity, then there exists r < n such that x = ζ^r or x = -ζ^r.

From flt-regular


Open in Gitpod

@riccardobrasca riccardobrasca added the WIP Work in progress label Feb 18, 2024
@riccardobrasca riccardobrasca changed the title Roots of cyclotomic polynomials in cyclotomic extensions feat: characterize roots of unity in cyclotomic extensions Feb 19, 2024
@riccardobrasca riccardobrasca added awaiting-review The author would like community review of the PR t-number-theory Number theory (also use t-algebra or t-analysis to specialize) t-algebra Algebra (groups, rings, fields etc) and removed WIP Work in progress labels Feb 19, 2024
Mathlib/Data/Nat/Totient.lean Outdated Show resolved Hide resolved
Mathlib/NumberTheory/Cyclotomic/PrimitiveRoots.lean Outdated Show resolved Hide resolved
Mathlib/NumberTheory/Cyclotomic/PrimitiveRoots.lean Outdated Show resolved Hide resolved
Mathlib/NumberTheory/Cyclotomic/PrimitiveRoots.lean Outdated Show resolved Hide resolved
Mathlib/NumberTheory/Cyclotomic/PrimitiveRoots.lean Outdated Show resolved Hide resolved
riccardobrasca and others added 6 commits February 19, 2024 15:30
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Michael Stoll <99838730+MichaelStollBayreuth@users.noreply.github.com>
@riccardobrasca riccardobrasca removed the awaiting-review The author would like community review of the PR label Mar 3, 2024
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 14, 2024
@riccardobrasca riccardobrasca added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 14, 2024
@Ruben-VandeVelde
Copy link
Collaborator

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@jcommelin
Copy link
Member

We add IsPrimitiveRoot.exists_neg_pow_mul_pow_of_pow_eq_one: if x is a k-th root of unity in an n-th cyclotomic extension, where n is odd, and ζ is a primitive n-th root of unity, then there exist r such that x = (-1)^r * ζ^r.

Please update the top post, since the name IsPrimitiveRoot.exists_neg_pow_mul_pow_of_pow_eq_one is no longer part of the diff.

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Mar 28, 2024

✌️ riccardobrasca can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Mar 28, 2024
@riccardobrasca
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Mar 28, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 28, 2024
We add `IsPrimitiveRoot.exists_pow_or_neg_mul_pow_of_isOfFinOrder`: If `x` is a root of unity (spelled as `IsOfFinOrder x`) in an `n`-th cyclotomic extension of `ℚ`, where `n` is odd, and `ζ` is a primitive `n`-th root of unity, then there exists `r < n` such that `x = ζ^r` or `x = -ζ^r`.

From flt-regular

- [x] depends on: #11235
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 28, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: characterize roots of unity in cyclotomic extensions [Merged by Bors] - feat: characterize roots of unity in cyclotomic extensions Mar 28, 2024
@mathlib-bors mathlib-bors bot closed this Mar 28, 2024
@mathlib-bors mathlib-bors bot deleted the RB/cycl_ex branch March 28, 2024 11:36
@alreadydone alreadydone restored the RB/cycl_ex branch March 28, 2024 16:41
@alreadydone alreadydone deleted the RB/cycl_ex branch March 28, 2024 16:43
Louddy pushed a commit that referenced this pull request Apr 15, 2024
We add `IsPrimitiveRoot.exists_pow_or_neg_mul_pow_of_isOfFinOrder`: If `x` is a root of unity (spelled as `IsOfFinOrder x`) in an `n`-th cyclotomic extension of `ℚ`, where `n` is odd, and `ζ` is a primitive `n`-th root of unity, then there exists `r < n` such that `x = ζ^r` or `x = -ζ^r`.

From flt-regular

- [x] depends on: #11235
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
We add `IsPrimitiveRoot.exists_pow_or_neg_mul_pow_of_isOfFinOrder`: If `x` is a root of unity (spelled as `IsOfFinOrder x`) in an `n`-th cyclotomic extension of `ℚ`, where `n` is odd, and `ζ` is a primitive `n`-th root of unity, then there exists `r < n` such that `x = ζ^r` or `x = -ζ^r`.

From flt-regular

- [x] depends on: #11235
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
We add `IsPrimitiveRoot.exists_pow_or_neg_mul_pow_of_isOfFinOrder`: If `x` is a root of unity (spelled as `IsOfFinOrder x`) in an `n`-th cyclotomic extension of `ℚ`, where `n` is odd, and `ζ` is a primitive `n`-th root of unity, then there exists `r < n` such that `x = ζ^r` or `x = -ζ^r`.

From flt-regular

- [x] depends on: #11235
callesonne pushed a commit that referenced this pull request Apr 22, 2024
We add `IsPrimitiveRoot.exists_pow_or_neg_mul_pow_of_isOfFinOrder`: If `x` is a root of unity (spelled as `IsOfFinOrder x`) in an `n`-th cyclotomic extension of `ℚ`, where `n` is odd, and `ζ` is a primitive `n`-th root of unity, then there exists `r < n` such that `x = ζ^r` or `x = -ζ^r`.

From flt-regular

- [x] depends on: #11235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated maintainer-merge ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc) t-number-theory Number theory (also use t-algebra or t-analysis to specialize)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants