Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: IsUnit if exists both inverses #10719

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - feat: IsUnit if exists both inverses #10719

wants to merge 12 commits into from

Conversation

XavierXarles
Copy link
Collaborator

@XavierXarles XavierXarles commented Feb 19, 2024 •
edited by adomani

Added one theorem

Open in Gitpod

@XavierXarles @github-actions
Update Mathlib/Algebra/Group/Units.lean
3bb24a5 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
XavierXarles and others added 2 commits February 19, 2024 15:48
@XavierXarles @eric-wieser
Update Mathlib/Algebra/Group/Units.lean
5ee54d6 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@XavierXarles
Update Units.lean
45eb6a4 
Changed proof using left_inv_eq_right_inv
@XavierXarles @github-actions
Update Mathlib/Algebra/Group/Units.lean
cbdfb88 
Spaces

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@XavierXarles @eric-wieser
Update Mathlib/Algebra/Group/Units.lean
139c4f5 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@XavierXarles @adomani
Update Mathlib/Algebra/Group/Units.lean
72d8aa6 
Co-authored-by: damiano <adomani@gmail.com>
@XavierXarles @adomani
Update Mathlib/Algebra/Group/Units.lean
db38e18 
Co-authored-by: damiano <adomani@gmail.com>
@adomani adomani mentioned this pull request Feb 22, 2024
Closed
@Ruben-VandeVelde
Copy link
Collaborator

Please merge master and make sure this lemma is next to the one added in #10832

@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-author A reviewer has asked the author a question or requested changes label Feb 22, 2024
@XavierXarles
Copy link
Collaborator Author

Please merge master and make sure this lemma is next to the one added in #10832

I really don't know how to merge master...

@adomani
Copy link
Collaborator

adomani commented Feb 22, 2024

@XavierXarles, I took care of merging master, moving the lemma and adding to doc-strings: I hope that you do not mind!

For future reference, if you use Git from the commandline, "merging master" likely looks as follows:

git fetch
git merge origin/master
##  maybe fix conflicts -- there were none this time

@adomani adomani added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 22, 2024
eric-wieser
eric-wieser approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks!

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Feb 23, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the awaiting-review The author would like community review of the PR label Feb 23, 2024
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) and removed ready-to-merge This PR has been sent to bors. labels Feb 23, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 23, 2024
@XavierXarles @adomani @eric-wieser
feat: IsUnit if exists both inverses (#10719)
73c76f6 
Added one theorem 



Co-authored-by: Xavier Xarles <56635243+XavierXarles@users.noreply.github.com>
Co-authored-by: adomani <adomani@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 23, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: IsUnit if exists both inverses [Merged by Bors] - feat: IsUnit if exists both inverses Feb 23, 2024
@mathlib-bors mathlib-bors bot closed this Feb 23, 2024
@mathlib-bors mathlib-bors bot deleted the Units branch February 23, 2024 01:41
thorimur pushed a commit that referenced this pull request Feb 24, 2024
@XavierXarles @adomani
@eric-wieser @thorimur
feat: IsUnit if exists both inverses (#10719)
77caebd 
Added one theorem 



Co-authored-by: Xavier Xarles <56635243+XavierXarles@users.noreply.github.com>
Co-authored-by: adomani <adomani@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
thorimur pushed a commit that referenced this pull request Feb 26, 2024
@XavierXarles @adomani
@eric-wieser @thorimur
feat: IsUnit if exists both inverses (#10719)
a01c938 
Added one theorem 



Co-authored-by: Xavier Xarles <56635243+XavierXarles@users.noreply.github.com>
Co-authored-by: adomani <adomani@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
riccardobrasca pushed a commit that referenced this pull request Mar 1, 2024
@XavierXarles @adomani
@eric-wieser @riccardobrasca
feat: IsUnit if exists both inverses (#10719)
b74588b 
Added one theorem 



Co-authored-by: Xavier Xarles <56635243+XavierXarles@users.noreply.github.com>
Co-authored-by: adomani <adomani@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@XavierXarles @adomani
@eric-wieser @dagurtomas
feat: IsUnit if exists both inverses (#10719)
25d3443 
Added one theorem 



Co-authored-by: Xavier Xarles <56635243+XavierXarles@users.noreply.github.com>
Co-authored-by: adomani <adomani@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Louddy pushed a commit that referenced this pull request Apr 15, 2024
@XavierXarles @adomani
@eric-wieser @Louddy
feat: IsUnit if exists both inverses (#10719)
d474821 
Added one theorem 



Co-authored-by: Xavier Xarles <56635243+XavierXarles@users.noreply.github.com>
Co-authored-by: adomani <adomani@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adomani adomani adomani left review comments

@github-actions github-actions[bot] github-actions left review comments

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@XavierXarles @Ruben-VandeVelde @adomani @eric-wieser @leanprover-community-mathlib4-bot