New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: replace Lean 3 syntax λ x,
in doc comments
#10727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…doc comments. This is close to exhaustive.
- Instead of repeating 'a function' or 'the same filter', name it. - Use semantic linebreaking slightly more: it's more robust long-term, and I have to touch these lines anyway. - Edit nearby docstrings for consistency. (Happy to revert that part.)
grunweg
added
the
awaiting-review
The author would like community review of the PR
label
Feb 19, 2024
grunweg
changed the title
chore: replace Lean 3 syntax λ x, in doc comments
chore: replace Lean 3 syntax Feb 19, 2024
λ x,
in doc comments
bors merge |
github-actions
bot
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
The author would like community review of the PR
labels
Feb 20, 2024
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
Use Lean 4 syntax `fun x ↦` instead, matching the style guide. This is close to exhaustive for doc comments; mathlib has about 460 remaining uses of λ (not all in Lean 3 syntax).
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
chore: replace Lean 3 syntax
[Merged by Bors] - chore: replace Lean 3 syntax Feb 20, 2024
λ x,
in doc commentsλ x,
in doc comments
thorimur
pushed a commit
that referenced
this pull request
Feb 24, 2024
Use Lean 4 syntax `fun x ↦` instead, matching the style guide. This is close to exhaustive for doc comments; mathlib has about 460 remaining uses of λ (not all in Lean 3 syntax).
thorimur
pushed a commit
that referenced
this pull request
Feb 26, 2024
Use Lean 4 syntax `fun x ↦` instead, matching the style guide. This is close to exhaustive for doc comments; mathlib has about 460 remaining uses of λ (not all in Lean 3 syntax).
riccardobrasca
pushed a commit
that referenced
this pull request
Mar 1, 2024
Use Lean 4 syntax `fun x ↦` instead, matching the style guide. This is close to exhaustive for doc comments; mathlib has about 460 remaining uses of λ (not all in Lean 3 syntax).
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
Use Lean 4 syntax `fun x ↦` instead, matching the style guide. This is close to exhaustive for doc comments; mathlib has about 460 remaining uses of λ (not all in Lean 3 syntax).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Lean 4 syntax
fun x ↦
instead, matching the style guide.This is close to exhaustive for doc comments; mathlib has about 460 remaining uses of λ (not all in Lean 3 syntax).