Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: replace Lean 3 syntax λ x, in doc comments #10727

Closed
wants to merge 3 commits into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Feb 19, 2024

Use Lean 4 syntax fun x ↦ instead, matching the style guide.
This is close to exhaustive for doc comments; mathlib has about 460 remaining uses of λ (not all in Lean 3 syntax).


Open in Gitpod

- Instead of repeating 'a function' or 'the same filter', name it.
- Use semantic linebreaking slightly more: it's more robust long-term,
and I have to touch these lines anyway.
- Edit nearby docstrings for consistency. (Happy to revert that part.)
@grunweg grunweg added the awaiting-review The author would like community review of the PR label Feb 19, 2024
@grunweg grunweg changed the title chore: replace Lean 3 syntax λ x, in doc comments chore: replace Lean 3 syntax λ x, in doc comments Feb 19, 2024
@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 20, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 20, 2024
Use Lean 4 syntax `fun x ↦` instead, matching the style guide.
This is close to exhaustive for doc comments; mathlib has about 460 remaining uses of λ (not all in Lean 3 syntax).
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 20, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: replace Lean 3 syntax λ x, in doc comments [Merged by Bors] - chore: replace Lean 3 syntax λ x, in doc comments Feb 20, 2024
@mathlib-bors mathlib-bors bot closed this Feb 20, 2024
@mathlib-bors mathlib-bors bot deleted the MR-lambda-syntax-comments branch February 20, 2024 10:08
thorimur pushed a commit that referenced this pull request Feb 24, 2024
Use Lean 4 syntax `fun x ↦` instead, matching the style guide.
This is close to exhaustive for doc comments; mathlib has about 460 remaining uses of λ (not all in Lean 3 syntax).
thorimur pushed a commit that referenced this pull request Feb 26, 2024
Use Lean 4 syntax `fun x ↦` instead, matching the style guide.
This is close to exhaustive for doc comments; mathlib has about 460 remaining uses of λ (not all in Lean 3 syntax).
riccardobrasca pushed a commit that referenced this pull request Mar 1, 2024
Use Lean 4 syntax `fun x ↦` instead, matching the style guide.
This is close to exhaustive for doc comments; mathlib has about 460 remaining uses of λ (not all in Lean 3 syntax).
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
Use Lean 4 syntax `fun x ↦` instead, matching the style guide.
This is close to exhaustive for doc comments; mathlib has about 460 remaining uses of λ (not all in Lean 3 syntax).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants