New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: classify was simp
porting notes
#10746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitmonticone
added
awaiting-review
The author would like community review of the PR
easy
< 20s of review time. See the lifecycle page for guidelines.
porting-notes
Mathlib3 to Mathlib4 porting notes.
labels
Feb 20, 2024
Vierkantor
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bors d+
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
The author would like community review of the PR
labels
Feb 20, 2024
✌️ pitmonticone can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
Classifies by adding issue number (#10745) to porting notes claiming `was simp`.
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
chore: classify
[Merged by Bors] - chore: classify Feb 20, 2024
was simp
porting noteswas simp
porting notes
thorimur
pushed a commit
that referenced
this pull request
Feb 24, 2024
Classifies by adding issue number (#10745) to porting notes claiming `was simp`.
thorimur
pushed a commit
that referenced
this pull request
Feb 26, 2024
Classifies by adding issue number (#10745) to porting notes claiming `was simp`.
riccardobrasca
pushed a commit
that referenced
this pull request
Mar 1, 2024
Classifies by adding issue number (#10745) to porting notes claiming `was simp`.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
Classifies by adding issue number (#10745) to porting notes claiming `was simp`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
delegated
easy
< 20s of review time. See the lifecycle page for guidelines.
porting-notes
Mathlib3 to Mathlib4 porting notes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classifies by adding issue number (#10745) to porting notes claiming
was simp
.