Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port Data.Nat.Bits #1075

Merged

Conversation

Shreyas4991
Copy link
Collaborator

First PR for data.nat.bits. Copied file Data/Nat/Bits.lean from mathlib3port as is.
Mathlib commit : d012cd09a9b256d870751284dd6a29882b0be105

@semorrison
Copy link
Contributor

Please reopen this as a PR from a branch on this repository, so that CI can run.

@semorrison semorrison added the awaiting-author A reviewer has asked the author a question or requested changes label Dec 17, 2022
@@ -0,0 +1 @@
d012cd09a9b256d870751284dd6a29882b0be105
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this file was intended to be committed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sorry. I shall remove it

@Shreyas4991
Copy link
Collaborator Author

Hi @semorrison

Is there a way to move this PR as required?

@Shreyas4991 Shreyas4991 reopened this Dec 18, 2022
@Shreyas4991 Shreyas4991 merged commit 2de613a into leanprover-community:data_nat_bits Dec 18, 2022
bors bot pushed a commit that referenced this pull request Dec 21, 2022
New Pull Request for data.nat.bits
Reasons for opening:
1. #1075 (comment)
2. https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/data.2Enat.2Ebits/near/316544221



Co-authored-by: ART0 <18333981+0Art0@users.noreply.github.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants