Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Algebra/Module/LinearMap/Basic): module structures of (semi)-linear maps over DomMulAct of a ring #10766

Closed
wants to merge 9 commits into from

Conversation

jjaassoonn
Copy link
Collaborator

splitted from #8559

These are written by @alreadydone


Open in Gitpod

Copy link
Contributor

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by alreadydone.

@riccardobrasca
Copy link
Member

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit b899b04.
There were significant changes against commit 85db972:

  Benchmark                                 Metric         Change
  ===============================================================
- ~Mathlib.Algebra.Module.LinearMap.Basic   instructions    27.4%

@eric-wieser
Copy link
Member

bors d+

Thanks!

@mathlib-bors
Copy link

mathlib-bors bot commented Feb 26, 2024

✌️ jjaassoonn can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@jjaassoonn
Copy link
Collaborator Author

Ones the CI passes, can you take another look before merging please @alreadydone

Copy link
Contributor

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
@jjaassoonn
Copy link
Collaborator Author

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Feb 27, 2024
…ear maps over `DomMulAct` of a ring (#10766)




splitted from #8559


These are written by @alreadydone 




Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 27, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/Module/LinearMap/Basic): module structures of (semi)-linear maps over DomMulAct of a ring [Merged by Bors] - feat(Algebra/Module/LinearMap/Basic): module structures of (semi)-linear maps over DomMulAct of a ring Feb 27, 2024
@mathlib-bors mathlib-bors bot closed this Feb 27, 2024
@mathlib-bors mathlib-bors bot deleted the module_DomMulAct_hom branch February 27, 2024 10:02
@alreadydone alreadydone restored the module_DomMulAct_hom branch February 27, 2024 11:50
@alreadydone alreadydone deleted the module_DomMulAct_hom branch February 27, 2024 11:50
riccardobrasca pushed a commit that referenced this pull request Mar 1, 2024
…ear maps over `DomMulAct` of a ring (#10766)




splitted from #8559


These are written by @alreadydone 




Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
…ear maps over `DomMulAct` of a ring (#10766)




splitted from #8559


These are written by @alreadydone 




Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
…ear maps over `DomMulAct` of a ring (#10766)




splitted from #8559


These are written by @alreadydone 




Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Louddy pushed a commit that referenced this pull request Apr 15, 2024
…ear maps over `DomMulAct` of a ring (#10766)




splitted from #8559


These are written by @alreadydone 




Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants