-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(UniformConvergenceTopology): add UniformOnFun.uniformity_eq
etc
#10784
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2b9b8fc
feat(UniformConvergenceTopology): add `UniformOnFun.uniformity_eq` etc
urkud 6dcc2ff
Merge branch 'master' into YK-unifconv-nhds
urkud 1e1a955
Fix
urkud 85e9ac7
Update Mathlib/Topology/UniformSpace/UniformConvergenceTopology.lean
urkud 3e637af
Merge branch 'master' into YK-unifconv-nhds
urkud 57f2488
Add a comment
urkud af985f3
Fix
urkud File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the proof much shorter. Should I restore some of the comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I'm a bit sad to see my proof go, mostly because I like this kind of argument, but I have no objective argument for keeping it (I suggested a slight golf though). As for comments, I'd say you could just add the following at the beginning of the proof, to match more accurately the new version:
-- This follows from the fact that `(— ∘ f) × (— ∘ f)` maps `gen (f '' t) V` to `gen t V`.