[Merged by Bors] - chore: Remove ball and bex from lemma names
#10816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ball` for "bounded forall" and `bex` for "bounded exists" are from experience very confusing abbreviations. This PR renames them to `forall_mem` and `exists_mem` in the few `Set` lemma names that mention them. Also deprecate `ball_image_of_ball`, `mem_image_elim`, `mem_image_elim_on` since those lemmas are duplicates of the renamed lemmas (apart from argument order and implicitness, which I am also fixing by making the binder in the RHS of `forall_mem_image` semi-implicit), have obscure names and are completely unused.
YaelDillies
added
awaiting-review
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
YaelDillies
force-pushed
the
banish_ball_bex
branch
from
4eb1964
to
c49c571
Compare
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
|
Let's get this in |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 6, 2024
`ball` for "bounded forall" and `bex` for "bounded exists" are from experience very confusing abbreviations. This PR renames them to `forall_mem` and `exists_mem` in the few `Set` lemma names that mention them. Also deprecate `ball_image_of_ball`, `mem_image_elim`, `mem_image_elim_on` since those lemmas are duplicates of the renamed lemmas (apart from argument order and implicitness, which I am also fixing by making the binder in the RHS of `forall_mem_image` semi-implicit), have obscure names and are completely unused.
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 6, 2024
`ball` for "bounded forall" and `bex` for "bounded exists" are from experience very confusing abbreviations. This PR renames them to `forall_mem` and `exists_mem` in the few `Set` lemma names that mention them. Also deprecate `ball_image_of_ball`, `mem_image_elim`, `mem_image_elim_on` since those lemmas are duplicates of the renamed lemmas (apart from argument order and implicitness, which I am also fixing by making the binder in the RHS of `forall_mem_image` semi-implicit), have obscure names and are completely unused.
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
`ball` for "bounded forall" and `bex` for "bounded exists" are from experience very confusing abbreviations. This PR renames them to `forall_mem` and `exists_mem` in the few `Set` lemma names that mention them. Also deprecate `ball_image_of_ball`, `mem_image_elim`, `mem_image_elim_on` since those lemmas are duplicates of the renamed lemmas (apart from argument order and implicitness, which I am also fixing by making the binder in the RHS of `forall_mem_image` semi-implicit), have obscure names and are completely unused.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
ball and bex from lemma namesball and bex from lemma names
urkud
added a commit
that referenced
this pull request
Mar 11, 2024
... as a `@[deprecated] alias` Also add dates to some theorems deprecated in #10816, deprecate `Set.exists_range_iff'`, and use `simp`-normal form in the definition of `ParacompactSpace`.
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
... as a `@[deprecated] alias` Also add dates to some theorems deprecated in #10816, deprecate `Set.exists_range_iff'`, and use `simp`-normal form in the definition of `ParacompactSpace`.
kbuzzard
pushed a commit
that referenced
this pull request
Mar 12, 2024
`ball` for "bounded forall" and `bex` for "bounded exists" are from experience very confusing abbreviations. This PR renames them to `forall_mem` and `exists_mem` in the few `Set` lemma names that mention them. Also deprecate `ball_image_of_ball`, `mem_image_elim`, `mem_image_elim_on` since those lemmas are duplicates of the renamed lemmas (apart from argument order and implicitness, which I am also fixing by making the binder in the RHS of `forall_mem_image` semi-implicit), have obscure names and are completely unused.
kbuzzard
pushed a commit
that referenced
this pull request
Mar 12, 2024
... as a `@[deprecated] alias` Also add dates to some theorems deprecated in #10816, deprecate `Set.exists_range_iff'`, and use `simp`-normal form in the definition of `ParacompactSpace`.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
`ball` for "bounded forall" and `bex` for "bounded exists" are from experience very confusing abbreviations. This PR renames them to `forall_mem` and `exists_mem` in the few `Set` lemma names that mention them. Also deprecate `ball_image_of_ball`, `mem_image_elim`, `mem_image_elim_on` since those lemmas are duplicates of the renamed lemmas (apart from argument order and implicitness, which I am also fixing by making the binder in the RHS of `forall_mem_image` semi-implicit), have obscure names and are completely unused.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
... as a `@[deprecated] alias` Also add dates to some theorems deprecated in #10816, deprecate `Set.exists_range_iff'`, and use `simp`-normal form in the definition of `ParacompactSpace`.
This was referenced Mar 23, 2024
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
`ball` for "bounded forall" and `bex` for "bounded exists" are from experience very confusing abbreviations. This PR renames them to `forall_mem` and `exists_mem` in the few `Set` lemma names that mention them. Also deprecate `ball_image_of_ball`, `mem_image_elim`, `mem_image_elim_on` since those lemmas are duplicates of the renamed lemmas (apart from argument order and implicitness, which I am also fixing by making the binder in the RHS of `forall_mem_image` semi-implicit), have obscure names and are completely unused.
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
... as a `@[deprecated] alias` Also add dates to some theorems deprecated in #10816, deprecate `Set.exists_range_iff'`, and use `simp`-normal form in the definition of `ParacompactSpace`.
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
Follow-up to #10816. Remaining places containing such lemmas are - `Option.bex_ne_none` and `Option.ball_ne_none`: defined in Lean core - `Nat.decidableBallLT` and `Nat.decidableBallLE`: defined in Lean core - `bef_def` is still used in a number of places and could be renamed - `BAll.imp_{left,right}`, `BEx.imp_{left,right}`, `BEx.intro` and `BEx.elim` I only audited the first ~150 lemmas mentioning "ball"; too many lemmas named after Metric.ball/openBall/closedBall. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
`ball` for "bounded forall" and `bex` for "bounded exists" are from experience very confusing abbreviations. This PR renames them to `forall_mem` and `exists_mem` in the few `Set` lemma names that mention them. Also deprecate `ball_image_of_ball`, `mem_image_elim`, `mem_image_elim_on` since those lemmas are duplicates of the renamed lemmas (apart from argument order and implicitness, which I am also fixing by making the binder in the RHS of `forall_mem_image` semi-implicit), have obscure names and are completely unused.
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
... as a `@[deprecated] alias` Also add dates to some theorems deprecated in #10816, deprecate `Set.exists_range_iff'`, and use `simp`-normal form in the definition of `ParacompactSpace`.
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
Follow-up to #10816. Remaining places containing such lemmas are - `Option.bex_ne_none` and `Option.ball_ne_none`: defined in Lean core - `Nat.decidableBallLT` and `Nat.decidableBallLE`: defined in Lean core - `bef_def` is still used in a number of places and could be renamed - `BAll.imp_{left,right}`, `BEx.imp_{left,right}`, `BEx.intro` and `BEx.elim` I only audited the first ~150 lemmas mentioning "ball"; too many lemmas named after Metric.ball/openBall/closedBall. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
Follow-up to #10816. Remaining places containing such lemmas are - `Option.bex_ne_none` and `Option.ball_ne_none`: defined in Lean core - `Nat.decidableBallLT` and `Nat.decidableBallLE`: defined in Lean core - `bef_def` is still used in a number of places and could be renamed - `BAll.imp_{left,right}`, `BEx.imp_{left,right}`, `BEx.intro` and `BEx.elim` I only audited the first ~150 lemmas mentioning "ball"; too many lemmas named after Metric.ball/openBall/closedBall. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
... as a `@[deprecated] alias` Also add dates to some theorems deprecated in #10816, deprecate `Set.exists_range_iff'`, and use `simp`-normal form in the definition of `ParacompactSpace`.
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
Follow-up to #10816. Remaining places containing such lemmas are - `Option.bex_ne_none` and `Option.ball_ne_none`: defined in Lean core - `Nat.decidableBallLT` and `Nat.decidableBallLE`: defined in Lean core - `bef_def` is still used in a number of places and could be renamed - `BAll.imp_{left,right}`, `BEx.imp_{left,right}`, `BEx.intro` and `BEx.elim` I only audited the first ~150 lemmas mentioning "ball"; too many lemmas named after Metric.ball/openBall/closedBall. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
`ball` for "bounded forall" and `bex` for "bounded exists" are from experience very confusing abbreviations. This PR renames them to `forall_mem` and `exists_mem` in the few `Set` lemma names that mention them. Also deprecate `ball_image_of_ball`, `mem_image_elim`, `mem_image_elim_on` since those lemmas are duplicates of the renamed lemmas (apart from argument order and implicitness, which I am also fixing by making the binder in the RHS of `forall_mem_image` semi-implicit), have obscure names and are completely unused.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
... as a `@[deprecated] alias` Also add dates to some theorems deprecated in #10816, deprecate `Set.exists_range_iff'`, and use `simp`-normal form in the definition of `ParacompactSpace`.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
Follow-up to #10816. Remaining places containing such lemmas are - `Option.bex_ne_none` and `Option.ball_ne_none`: defined in Lean core - `Nat.decidableBallLT` and `Nat.decidableBallLE`: defined in Lean core - `bef_def` is still used in a number of places and could be renamed - `BAll.imp_{left,right}`, `BEx.imp_{left,right}`, `BEx.intro` and `BEx.elim` I only audited the first ~150 lemmas mentioning "ball"; too many lemmas named after Metric.ball/openBall/closedBall. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ballfor "bounded forall" andbexfor "bounded exists" are from experience very confusing abbreviations. This PR renames them toforall_memandexists_memin the fewSetlemma names that mention them.Also deprecate
ball_image_of_ball,mem_image_elim,mem_image_elim_onsince those lemmas are duplicates of the renamed lemmas (apart from argument order and implicitness, which I am also fixing by making the binder in the RHS offorall_mem_imagesemi-implicit), have obscure names and are completely unused.