Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Semicontinuity of f ∘ g for f semicontinuous, g continuous #10822

Closed
wants to merge 2 commits into from

Conversation

girving
Copy link
Collaborator

@girving girving commented Feb 21, 2024

Only the other direction exists currently, it seems.


Open in Gitpod

@girving girving added awaiting-review The author would like community review of the PR t-topology Topological spaces, uniform spaces, metric spaces, filters labels Feb 21, 2024
@girving
Copy link
Collaborator Author

girving commented Feb 23, 2024

The main question is whether I should rename these .comp_continuousAt. They're .comp currently because there's a canonical thing you can right-compose semicontinuity with, but .comp_continuousAt might be less surprising.

Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I would probably call them .comp_continuousAt and so on, for clarity.

Mathlib/Topology/Semicontinuous.lean Show resolved Hide resolved
Mathlib/Topology/Semicontinuous.lean Outdated Show resolved Hide resolved
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 12, 2024
@girving girving added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 12, 2024
@sgouezel
Copy link
Contributor

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 15, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 15, 2024
#10822)

Only the other direction exists currently, it seems.
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 15, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Semicontinuity of f ∘ g for f semicontinuous, g continuous [Merged by Bors] - feat: Semicontinuity of f ∘ g for f semicontinuous, g continuous Mar 15, 2024
@mathlib-bors mathlib-bors bot closed this Mar 15, 2024
@mathlib-bors mathlib-bors bot deleted the GI_semi branch March 15, 2024 16:36
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
#10822)

Only the other direction exists currently, it seems.
utensil pushed a commit that referenced this pull request Mar 26, 2024
#10822)

Only the other direction exists currently, it seems.
Louddy pushed a commit that referenced this pull request Apr 15, 2024
#10822)

Only the other direction exists currently, it seems.
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
#10822)

Only the other direction exists currently, it seems.
callesonne pushed a commit that referenced this pull request Apr 22, 2024
#10822)

Only the other direction exists currently, it seems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants