[Merged by Bors] - feat: port Data.Fin.Basic #1084
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-loreaux
added
mathlib-port
eric-wieser
reviewed
Jan 12, 2023
eric-wieser
previously requested changes
Jan 12, 2023
eric-wieser
reviewed
Jan 12, 2023
This refactor was in the ad-hoc code, but is a distraction from the port, and isn't a clear win anyway.
jcommelin
changed the base branch from
j-loreaux/data.fin.basic-mathport
to
master
|
Thanks 🎉 bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jan 12, 2023
mathlib3 SHA: 0bd2ea37bcba5769e14866170f251c9bc64e35d7 Co-authored-by: Moritz Doll <moritz.doll@googlemail.com> Co-authored-by: Johan Commelin <johan@commelin.net>
github-actions
bot
removed
the
awaiting-review
|
Canceled. |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jan 12, 2023
mathlib3 SHA: 0bd2ea37bcba5769e14866170f251c9bc64e35d7 Co-authored-by: Moritz Doll <moritz.doll@googlemail.com> Co-authored-by: Johan Commelin <johan@commelin.net>
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
alreadydone
reviewed
Jan 12, 2023
Comment on lines
+2482
to
+2491
| @[simp] | ||
| theorem coe_ofNat_eq_mod' (m n : ℕ) [NeZero m] : | ||
| (@Fin.ofNat' m n (Nat.pos_of_ne_zero (NeZero.ne m)) : ℕ) = n % m := | ||
| rfl | ||
| #align fin.coe_of_nat_eq_mod' Fin.coe_ofNat_eq_mod' | ||
|
|
||
| @[simp] | ||
| theorem coe_of_nat_eq_mod (m n : ℕ) : ((n : Fin (m+1)) : ℕ) = n % Nat.succ m := | ||
| rfl | ||
| #align fin.coe_of_nat_eq_mod Fin.coe_of_nat_eq_mod |
There was a problem hiding this comment.
seems we need a matching PR to #18131. @negiizhao will you do it?
There was a problem hiding this comment.
Just noticed the LHS of these two theorems look syntactically different, but they were the same in mathlib3. The latter is now removed from mathlib3, and the former is renamed to the latter, so the first #align should fail and the second #align should be a misalignment now. Can we change the statement of the former to ((n : Fin m) : ℕ) = n % m and remove the latter?
jcommelin
added a commit
that referenced
this pull request
Jan 23, 2023
mathlib3 SHA: 0bd2ea37bcba5769e14866170f251c9bc64e35d7 Co-authored-by: Moritz Doll <moritz.doll@googlemail.com> Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mathlib3 SHA: 0bd2ea37bcba5769e14866170f251c9bc64e35d7