Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Lemmas about (extChartAt I x).target being open if we're boundaryless #10840

Closed
wants to merge 4 commits into from

Conversation

girving
Copy link
Collaborator

@girving girving commented Feb 21, 2024

(extChartAt I x).source is always open, so there are nice lemmas like

  1. isOpen_extChartAt_source
  2. extChartAt_source_mem_nhds
  3. extChartAt_source_mem_nhds'

(extChartAt I x).target fails to be open near manifold boundary points, but we recover the nice lemmas when I.Boundaryless.


Open in Gitpod

…daryless

`(extChartAt I x).source` is always open, so there are nice lemmas like

1. `isOpen_extChartAt_source`
2. `extChartAt_source_mem_nhds`
3. `extChartAt_source_mem_nhds'`

`(extChartAt I x).target` fails to be open near manifold boundary
points, but we recover the nice lemmas when `I.Boundaryless`.
@girving girving added awaiting-review The author would like community review of the PR t-differential-geometry Manifolds etc labels Feb 21, 2024
Copy link
Member

@fpvandoorn fpvandoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Mathlib/Geometry/Manifold/SmoothManifoldWithCorners.lean Outdated Show resolved Hide resolved
Mathlib/Geometry/Manifold/SmoothManifoldWithCorners.lean Outdated Show resolved Hide resolved
Mathlib/Geometry/Manifold/SmoothManifoldWithCorners.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 21, 2024

✌️ girving can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Feb 21, 2024
girving and others added 3 commits February 22, 2024 00:08
Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
@girving
Copy link
Collaborator Author

girving commented Feb 22, 2024

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Feb 22, 2024
…daryless (#10840)

`(extChartAt I x).source` is always open, so there are nice lemmas like

1. `isOpen_extChartAt_source`
2. `extChartAt_source_mem_nhds`
3. `extChartAt_source_mem_nhds'`

`(extChartAt I x).target` fails to be open near manifold boundary points, but we recover the nice lemmas when `I.Boundaryless`.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 22, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Lemmas about (extChartAt I x).target being open if we're boundaryless [Merged by Bors] - feat: Lemmas about (extChartAt I x).target being open if we're boundaryless Feb 22, 2024
@mathlib-bors mathlib-bors bot closed this Feb 22, 2024
@mathlib-bors mathlib-bors bot deleted the GI_target branch February 22, 2024 01:18
thorimur pushed a commit that referenced this pull request Feb 24, 2024
…daryless (#10840)

`(extChartAt I x).source` is always open, so there are nice lemmas like

1. `isOpen_extChartAt_source`
2. `extChartAt_source_mem_nhds`
3. `extChartAt_source_mem_nhds'`

`(extChartAt I x).target` fails to be open near manifold boundary points, but we recover the nice lemmas when `I.Boundaryless`.
thorimur pushed a commit that referenced this pull request Feb 26, 2024
…daryless (#10840)

`(extChartAt I x).source` is always open, so there are nice lemmas like

1. `isOpen_extChartAt_source`
2. `extChartAt_source_mem_nhds`
3. `extChartAt_source_mem_nhds'`

`(extChartAt I x).target` fails to be open near manifold boundary points, but we recover the nice lemmas when `I.Boundaryless`.
riccardobrasca pushed a commit that referenced this pull request Mar 1, 2024
…daryless (#10840)

`(extChartAt I x).source` is always open, so there are nice lemmas like

1. `isOpen_extChartAt_source`
2. `extChartAt_source_mem_nhds`
3. `extChartAt_source_mem_nhds'`

`(extChartAt I x).target` fails to be open near manifold boundary points, but we recover the nice lemmas when `I.Boundaryless`.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
…daryless (#10840)

`(extChartAt I x).source` is always open, so there are nice lemmas like

1. `isOpen_extChartAt_source`
2. `extChartAt_source_mem_nhds`
3. `extChartAt_source_mem_nhds'`

`(extChartAt I x).target` fails to be open near manifold boundary points, but we recover the nice lemmas when `I.Boundaryless`.
Louddy pushed a commit that referenced this pull request Apr 15, 2024
…daryless (#10840)

`(extChartAt I x).source` is always open, so there are nice lemmas like

1. `isOpen_extChartAt_source`
2. `extChartAt_source_mem_nhds`
3. `extChartAt_source_mem_nhds'`

`(extChartAt I x).target` fails to be open near manifold boundary points, but we recover the nice lemmas when `I.Boundaryless`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants