Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: replace #eval by run_cmd in Funlike/Basic #10848

Closed
wants to merge 1 commit into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Feb 22, 2024

This is the only #eval used in Mathlib.


Open in Gitpod

@adomani adomani added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI labels Feb 22, 2024
@semorrison
Copy link
Contributor

bors merge

@mathlib-bors
Copy link

mathlib-bors bot commented Feb 22, 2024

👎 Rejected by label

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 22, 2024
@Vierkantor
Copy link
Contributor

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Feb 22, 2024

✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@adomani
Copy link
Collaborator Author

adomani commented Feb 22, 2024

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Feb 22, 2024
This is the only `#eval` used in `Mathlib`.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 22, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Feb 22, 2024
This is the only `#eval` used in `Mathlib`.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 22, 2024

This PR was included in a batch that was canceled, it will be automatically retried

mathlib-bors bot pushed a commit that referenced this pull request Feb 22, 2024
This is the only `#eval` used in `Mathlib`.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 22, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: replace #eval by run_cmd in Funlike/Basic [Merged by Bors] - chore: replace #eval by run_cmd in Funlike/Basic Feb 22, 2024
@mathlib-bors mathlib-bors bot closed this Feb 22, 2024
@mathlib-bors mathlib-bors bot deleted the adomani/eval_to_run_cmd branch February 22, 2024 14:00
mathlib-bors bot pushed a commit that referenced this pull request Feb 22, 2024
Lint against `#eval`s in `Mathlib`.

This PR is built on top of #10848.
thorimur pushed a commit that referenced this pull request Feb 24, 2024
This is the only `#eval` used in `Mathlib`.
thorimur pushed a commit that referenced this pull request Feb 24, 2024
Lint against `#eval`s in `Mathlib`.

This PR is built on top of #10848.
thorimur pushed a commit that referenced this pull request Feb 26, 2024
This is the only `#eval` used in `Mathlib`.
thorimur pushed a commit that referenced this pull request Feb 26, 2024
Lint against `#eval`s in `Mathlib`.

This PR is built on top of #10848.
adomani added a commit that referenced this pull request Feb 27, 2024
This is the only `#eval` used in `Mathlib`.
riccardobrasca pushed a commit that referenced this pull request Mar 1, 2024
This is the only `#eval` used in `Mathlib`.
riccardobrasca pushed a commit that referenced this pull request Mar 1, 2024
Lint against `#eval`s in `Mathlib`.

This PR is built on top of #10848.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
This is the only `#eval` used in `Mathlib`.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
Lint against `#eval`s in `Mathlib`.

This PR is built on top of #10848.
Louddy pushed a commit that referenced this pull request Apr 15, 2024
This is the only `#eval` used in `Mathlib`.
Louddy pushed a commit that referenced this pull request Apr 15, 2024
Lint against `#eval`s in `Mathlib`.

This PR is built on top of #10848.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants