-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(NoncommPiCoprod): drop some DecidableEq
assumptions
#10862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `letI := Classical.decEq ι` to make Lean use the classical instance instead of the one in the `variable`s.
urkud
added
awaiting-review
The author would like community review of the PR
t-algebra
Algebra (groups, rings, fields etc)
t-logic
Logic (model theory, set theory, etc)
labels
Feb 22, 2024
eric-wieser
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
Thanks!
leanprover-community-mathlib4-bot
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
The author would like community review of the PR
labels
Feb 22, 2024
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
Use `letI := Classical.decEq ι` to make Lean use the classical instance instead of the one in the `variable`s.
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
chore(NoncommPiCoprod): drop some
[Merged by Bors] - chore(NoncommPiCoprod): drop some Feb 23, 2024
DecidableEq
assumptionsDecidableEq
assumptions
thorimur
pushed a commit
that referenced
this pull request
Feb 24, 2024
Use `letI := Classical.decEq ι` to make Lean use the classical instance instead of the one in the `variable`s.
thorimur
pushed a commit
that referenced
this pull request
Feb 26, 2024
Use `letI := Classical.decEq ι` to make Lean use the classical instance instead of the one in the `variable`s.
riccardobrasca
pushed a commit
that referenced
this pull request
Mar 1, 2024
Use `letI := Classical.decEq ι` to make Lean use the classical instance instead of the one in the `variable`s.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
Use `letI := Classical.decEq ι` to make Lean use the classical instance instead of the one in the `variable`s.
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
Use `letI := Classical.decEq ι` to make Lean use the classical instance instead of the one in the `variable`s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
This PR has been sent to bors.
t-algebra
Algebra (groups, rings, fields etc)
t-logic
Logic (model theory, set theory, etc)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
letI := Classical.decEq ι
to make Lean use the classical instance
instead of the one in the
variable
s.