[Merged by Bors] - chore: rename induction principle arguments around CliffordAlgebra
#10908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
the
awaiting-review
Ruben-VandeVelde
approved these changes
Feb 28, 2024
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
leanprover-community-mathlib4-bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
…10908) In order to improve the ergonomics of the `induction` tactic, this renames the arguments of: * `ExteriorAlgebra.induction` * `TensorAlgebra.induction` * `CliffordAlgebra.induction` * `CliffordAlgebra.left_induction` * `CliffordAlgebra.right_induction` * `CliffordAlgebra.even_induction` * `CliffordAlgebra.odd_induction` * `Submodule.iSup_induction'` * `Submodule.pow_induction_on_left'` * `Submodule.pow_induction_on_right'` This is slightly awkward for name-resolution within these induction principles, as the argument names end up clashing with the function they are about. Thankfully, this pain is not transferred to the caller using `induction _ using _`.
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
…10908) In order to improve the ergonomics of the `induction` tactic, this renames the arguments of: * `ExteriorAlgebra.induction` * `TensorAlgebra.induction` * `CliffordAlgebra.induction` * `CliffordAlgebra.left_induction` * `CliffordAlgebra.right_induction` * `CliffordAlgebra.even_induction` * `CliffordAlgebra.odd_induction` * `Submodule.iSup_induction'` * `Submodule.pow_induction_on_left'` * `Submodule.pow_induction_on_right'` This is slightly awkward for name-resolution within these induction principles, as the argument names end up clashing with the function they are about. Thankfully, this pain is not transferred to the caller using `induction _ using _`.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
CliffordAlgebraCliffordAlgebra
kbuzzard
pushed a commit
that referenced
this pull request
Mar 12, 2024
…10908) In order to improve the ergonomics of the `induction` tactic, this renames the arguments of: * `ExteriorAlgebra.induction` * `TensorAlgebra.induction` * `CliffordAlgebra.induction` * `CliffordAlgebra.left_induction` * `CliffordAlgebra.right_induction` * `CliffordAlgebra.even_induction` * `CliffordAlgebra.odd_induction` * `Submodule.iSup_induction'` * `Submodule.pow_induction_on_left'` * `Submodule.pow_induction_on_right'` This is slightly awkward for name-resolution within these induction principles, as the argument names end up clashing with the function they are about. Thankfully, this pain is not transferred to the caller using `induction _ using _`.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
…10908) In order to improve the ergonomics of the `induction` tactic, this renames the arguments of: * `ExteriorAlgebra.induction` * `TensorAlgebra.induction` * `CliffordAlgebra.induction` * `CliffordAlgebra.left_induction` * `CliffordAlgebra.right_induction` * `CliffordAlgebra.even_induction` * `CliffordAlgebra.odd_induction` * `Submodule.iSup_induction'` * `Submodule.pow_induction_on_left'` * `Submodule.pow_induction_on_right'` This is slightly awkward for name-resolution within these induction principles, as the argument names end up clashing with the function they are about. Thankfully, this pain is not transferred to the caller using `induction _ using _`.
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
…10908) In order to improve the ergonomics of the `induction` tactic, this renames the arguments of: * `ExteriorAlgebra.induction` * `TensorAlgebra.induction` * `CliffordAlgebra.induction` * `CliffordAlgebra.left_induction` * `CliffordAlgebra.right_induction` * `CliffordAlgebra.even_induction` * `CliffordAlgebra.odd_induction` * `Submodule.iSup_induction'` * `Submodule.pow_induction_on_left'` * `Submodule.pow_induction_on_right'` This is slightly awkward for name-resolution within these induction principles, as the argument names end up clashing with the function they are about. Thankfully, this pain is not transferred to the caller using `induction _ using _`.
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
…10908) In order to improve the ergonomics of the `induction` tactic, this renames the arguments of: * `ExteriorAlgebra.induction` * `TensorAlgebra.induction` * `CliffordAlgebra.induction` * `CliffordAlgebra.left_induction` * `CliffordAlgebra.right_induction` * `CliffordAlgebra.even_induction` * `CliffordAlgebra.odd_induction` * `Submodule.iSup_induction'` * `Submodule.pow_induction_on_left'` * `Submodule.pow_induction_on_right'` This is slightly awkward for name-resolution within these induction principles, as the argument names end up clashing with the function they are about. Thankfully, this pain is not transferred to the caller using `induction _ using _`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to improve the ergonomics of the
inductiontactic, this renames the arguments of:ExteriorAlgebra.inductionTensorAlgebra.inductionCliffordAlgebra.inductionCliffordAlgebra.left_inductionCliffordAlgebra.right_inductionCliffordAlgebra.even_inductionCliffordAlgebra.odd_inductionSubmodule.iSup_induction'Submodule.pow_induction_on_left'Submodule.pow_induction_on_right'This is slightly awkward for name-resolution within these induction principles, as the argument names end up clashing with the function they are about. Thankfully, this pain is not transferred to the caller using
induction _ using _.