Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting note: removed @[nolint has_nonempty_instance] #10927

Closed
pitmonticone opened this issue Feb 24, 2024 · 2 comments
Closed

Porting note: removed @[nolint has_nonempty_instance] #10927

pitmonticone opened this issue Feb 24, 2024 · 2 comments
Labels
porting-notes Mathlib3 to Mathlib4 porting notes.

Comments

@pitmonticone
Copy link
Collaborator

Classifies porting notes claiming removed @[nolint has_nonempty_instance].

Examples

-- porting note: removed @[nolint has_nonempty_instance]
/-- The category of simplicial objects valued in a category `C`.
This is the category of contravariant functors from `SimplexCategory` to `C`. -/
def SimplicialObject :=
SimplexCategoryᵒᵖ ⥤ C
#align category_theory.simplicial_object CategoryTheory.SimplicialObject

-- porting note: removed @[nolint has_nonempty_instance]
/-- Cosimplicial objects. -/
def CosimplicialObject :=
SimplexCategory ⥤ C
#align category_theory.cosimplicial_object CategoryTheory.CosimplicialObject

-- Porting note: removed @[nolint has_nonempty_instance]
@[ext]
structure LiftStruct (sq : CommSq f i p g) where
/-- The lift. -/
l : B ⟶ X
/-- The upper left triangle commutes. -/
fac_left : i ≫ l = f
/-- The lower right triangle commutes. -/
fac_right: l ≫ p = g
#align category_theory.comm_sq.lift_struct CategoryTheory.CommSq.LiftStruct

@pitmonticone pitmonticone added the porting-notes Mathlib3 to Mathlib4 porting notes. label Feb 24, 2024
mathlib-bors bot pushed a commit that referenced this issue Feb 25, 2024
…es (#10929)

Classifies by adding issue number (#10927) to porting notes claiming `removed @[nolint has_nonempty_instance]`.
riccardobrasca pushed a commit that referenced this issue Mar 1, 2024
…es (#10929)

Classifies by adding issue number (#10927) to porting notes claiming `removed @[nolint has_nonempty_instance]`.
dagurtomas pushed a commit that referenced this issue Mar 22, 2024
…es (#10929)

Classifies by adding issue number (#10927) to porting notes claiming `removed @[nolint has_nonempty_instance]`.
@grunweg
Copy link
Collaborator

grunweg commented Apr 12, 2024

This is a special case of porting notes caused by #5171; does it make sense to reference that issue instead?

mathlib-bors bot pushed a commit that referenced this issue Apr 13, 2024
Reference the newly created issues #12094 and #12096, as well as the pre-existing #5171.
Change all references to #10927 to #5171.
Some of these changes were not labelled as "porting note"; change this for good measure.
@grunweg
Copy link
Collaborator

grunweg commented Apr 14, 2024

I have changed all references to point to #5171 instead; let me close this issue. Thanks for classifying all these!

@grunweg grunweg closed this as completed Apr 14, 2024
Louddy pushed a commit that referenced this issue Apr 15, 2024
…es (#10929)

Classifies by adding issue number (#10927) to porting notes claiming `removed @[nolint has_nonempty_instance]`.
Louddy pushed a commit that referenced this issue Apr 15, 2024
Reference the newly created issues #12094 and #12096, as well as the pre-existing #5171.
Change all references to #10927 to #5171.
Some of these changes were not labelled as "porting note"; change this for good measure.
atarnoam pushed a commit that referenced this issue Apr 16, 2024
Reference the newly created issues #12094 and #12096, as well as the pre-existing #5171.
Change all references to #10927 to #5171.
Some of these changes were not labelled as "porting note"; change this for good measure.
uniwuni pushed a commit that referenced this issue Apr 19, 2024
Reference the newly created issues #12094 and #12096, as well as the pre-existing #5171.
Change all references to #10927 to #5171.
Some of these changes were not labelled as "porting note"; change this for good measure.
callesonne pushed a commit that referenced this issue Apr 22, 2024
Reference the newly created issues #12094 and #12096, as well as the pre-existing #5171.
Change all references to #10927 to #5171.
Some of these changes were not labelled as "porting note"; change this for good measure.
Jun2M pushed a commit that referenced this issue Apr 24, 2024
Reference the newly created issues #12094 and #12096, as well as the pre-existing #5171.
Change all references to #10927 to #5171.
Some of these changes were not labelled as "porting note"; change this for good measure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
porting-notes Mathlib3 to Mathlib4 porting notes.
Projects
None yet
Development

No branches or pull requests

2 participants