Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: classify removed @[nolint has_nonempty_instance] porting notes #10929

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - chore: classify removed @[nolint has_nonempty_instance] porting notes #10929

wants to merge 3 commits into from

Conversation

pitmonticone
Copy link
Collaborator

Classifies by adding issue number (#10927) to porting notes claiming removed @[nolint has_nonempty_instance].

@pitmonticone pitmonticone added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. porting-notes Mathlib3 to Mathlib4 porting notes. labels Feb 24, 2024
eric-wieser
eric-wieser approved these changes Feb 25, 2024
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks!

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 25, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 25, 2024
@pitmonticone
chore: classify removed @[nolint has_nonempty_instance] porting not…
2599c3b 
…es (#10929)

Classifies by adding issue number (#10927) to porting notes claiming `removed @[nolint has_nonempty_instance]`.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 25, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: classify removed @[nolint has_nonempty_instance] porting notes [Merged by Bors] - chore: classify removed @[nolint has_nonempty_instance] porting notes Feb 25, 2024
@mathlib-bors mathlib-bors bot closed this Feb 25, 2024
@mathlib-bors mathlib-bors bot deleted the pitmonticone/removed-nolint branch February 25, 2024 14:49
riccardobrasca pushed a commit that referenced this pull request Mar 1, 2024
@pitmonticone @riccardobrasca
chore: classify removed @[nolint has_nonempty_instance] porting not…
99f85fb 
…es (#10929)

Classifies by adding issue number (#10927) to porting notes claiming `removed @[nolint has_nonempty_instance]`.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@pitmonticone @dagurtomas
chore: classify removed @[nolint has_nonempty_instance] porting not…
9f4034a 
…es (#10929)

Classifies by adding issue number (#10927) to porting notes claiming `removed @[nolint has_nonempty_instance]`.
Louddy pushed a commit that referenced this pull request Apr 15, 2024
@pitmonticone @Louddy
chore: classify removed @[nolint has_nonempty_instance] porting not…
4e42309 
…es (#10929)

Classifies by adding issue number (#10927) to porting notes claiming `removed @[nolint has_nonempty_instance]`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. porting-notes Mathlib3 to Mathlib4 porting notes. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pitmonticone @eric-wieser @leanprover-community-mathlib4-bot