[Merged by Bors] - chore(Data/Finsupp/Defs): rename instances #10976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the `inst` prefix that is expected in Lean 4. All the changes to downstream files are fallout, no names have been changed there.
eric-wieser
added
awaiting-review
eric-wieser
commented
Feb 25, 2024
| @@ -1456,7 +1456,7 @@ instance nonUnitalCommSemiring [CommSemiring k] [AddCommSemigroup G] : | |||
| #align add_monoid_algebra.non_unital_comm_semiring AddMonoidAlgebra.nonUnitalCommSemiring | |||
|
|
|||
| instance nontrivial [Semiring k] [Nontrivial k] [Nonempty G] : Nontrivial k[G] := | |||
There was a problem hiding this comment.
Renaming these instance can come in a later PR.
|
maintainer merge I don't think aliases are needed for instances |
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
|
Thanks! 🎉 |
|
Thanks! bors merge |
|
Already running a review |
github-actions
bot
removed
the
awaiting-review
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
This adds the `inst` prefix that is expected in Lean 4. Performed using the F2 shortcut (renaming `foo` to `Finsupp.instFoo`, then deleting the redundant `Finsupp`) All the changes to downstream files are fallout, no names have been changed there.
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
This adds the `inst` prefix that is expected in Lean 4. Performed using the F2 shortcut (renaming `foo` to `Finsupp.instFoo`, then deleting the redundant `Finsupp`) All the changes to downstream files are fallout, no names have been changed there.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
kbuzzard
pushed a commit
that referenced
this pull request
Mar 12, 2024
This adds the `inst` prefix that is expected in Lean 4. Performed using the F2 shortcut (renaming `foo` to `Finsupp.instFoo`, then deleting the redundant `Finsupp`) All the changes to downstream files are fallout, no names have been changed there.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
This adds the `inst` prefix that is expected in Lean 4. Performed using the F2 shortcut (renaming `foo` to `Finsupp.instFoo`, then deleting the redundant `Finsupp`) All the changes to downstream files are fallout, no names have been changed there.
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
This adds the `inst` prefix that is expected in Lean 4. Performed using the F2 shortcut (renaming `foo` to `Finsupp.instFoo`, then deleting the redundant `Finsupp`) All the changes to downstream files are fallout, no names have been changed there.
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
This adds the `inst` prefix that is expected in Lean 4. Performed using the F2 shortcut (renaming `foo` to `Finsupp.instFoo`, then deleting the redundant `Finsupp`) All the changes to downstream files are fallout, no names have been changed there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
instprefix that is expected in Lean 4.Performed using the F2 shortcut (renaming
footoFinsupp.instFoo, then deleting the redundantFinsupp)All the changes to downstream files are fallout, no names have been changed there.