[Merged by Bors] - chore: use set and manually rewrite #10980
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
leanprover-community-mathlib4-bot
added
the
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
This is an attempt to fix `Mathlib/Algebra/ContinuedFractions/Computation/CorrectnessTerminating.lean`. I replaced some `let`s by `set`s and used rewrites when `field_simp` seemed to unfold the lets. [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Help.20with.20.60nightly-testing.60)
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
mathlib-bors
bot
deleted the
adomani/Correctenss_terminating_dsimp_by_hand
branch
riccardobrasca
pushed a commit
that referenced
this pull request
Mar 1, 2024
This is an attempt to fix `Mathlib/Algebra/ContinuedFractions/Computation/CorrectnessTerminating.lean`. I replaced some `let`s by `set`s and used rewrites when `field_simp` seemed to unfold the lets. [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Help.20with.20.60nightly-testing.60)
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
This is an attempt to fix `Mathlib/Algebra/ContinuedFractions/Computation/CorrectnessTerminating.lean`. I replaced some `let`s by `set`s and used rewrites when `field_simp` seemed to unfold the lets. [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Help.20with.20.60nightly-testing.60)
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
This is an attempt to fix `Mathlib/Algebra/ContinuedFractions/Computation/CorrectnessTerminating.lean`. I replaced some `let`s by `set`s and used rewrites when `field_simp` seemed to unfold the lets. [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Help.20with.20.60nightly-testing.60)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix
Mathlib/Algebra/ContinuedFractions/Computation/CorrectnessTerminating.lean.I replaced some
lets bysets and used rewrites whenfield_simpseemed to unfold the lets.Zulip discussion