Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Pi.Lex #1104

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat: port Data.Pi.Lex #1104

wants to merge 9 commits into from

Conversation

javra
Copy link
Collaborator

@javra javra commented Dec 19, 2022

mathlib3 SHA: d4f69d96f3532729da8ebb763f4bc26fcf640f06

@javra javra added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Dec 19, 2022
@javra javra removed the WIP Work in progress label Dec 19, 2022
@javra javra added the awaiting-review The author would like community review of the PR label Dec 19, 2022
Ruben-VandeVelde
Ruben-VandeVelde requested changes Dec 19, 2022
View reviewed changes
Mathlib/Data/Pi/Lex.lean Outdated Show resolved Hide resolved
Mathlib/Data/Pi/Lex.lean Outdated Show resolved Hide resolved
Mathlib/Data/Pi/Lex.lean Outdated Show resolved Hide resolved
Mathlib/Data/Pi/Lex.lean Outdated Show resolved Hide resolved
Mathlib/Order/Max.lean Outdated Show resolved Hide resolved
@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed awaiting-review The author would like community review of the PR labels Dec 20, 2022
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 20, 2022
@javra javra added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 20, 2022
jcommelin
jcommelin approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 20, 2022
bors bot pushed a commit that referenced this pull request Dec 20, 2022
@javra
feat: port Data.Pi.Lex (#1104)
db9b53a 
mathlib3 SHA: d4f69d96f3532729da8ebb763f4bc26fcf640f06
@bors
Copy link

bors bot commented Dec 20, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Pi.Lex [Merged by Bors] - feat: port Data.Pi.Lex Dec 20, 2022
@bors bors bot closed this Dec 20, 2022
@bors bors bot deleted the port-data-pi-lex branch December 20, 2022 14:00
@github-actions github-actions bot mentioned this pull request Dec 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde requested changes

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@javra @jcommelin @Ruben-VandeVelde @semorrison