Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: simplify proof of IsPiSystem.comap #11052

Closed
wants to merge 4 commits into from

Conversation

dwrensha
Copy link
Member

@dwrensha dwrensha commented Feb 28, 2024

Uses Set.not_nonempty_iff_eq_empty to shorten the proof of IsPiSystem.comap.


Open in Gitpod

@dwrensha
Copy link
Member Author

dwrensha commented Feb 28, 2024

I found this with tryAtEachStep.

@dwrensha dwrensha added the awaiting-review The author would like community review of the PR label Feb 28, 2024
Comment on lines 108 to 109
refine' ⟨s ∩ t, h_pi s hs_mem t ht_mem _, rfl⟩
by_contra h
rw [Set.not_nonempty_iff_eq_empty] at h
rw [h] at hst
simp at hst
exact nonempty_of_nonempty_preimage hst
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you can even collapse this into the previous line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 9b8d5ad.

@Ruben-VandeVelde Ruben-VandeVelde added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 5, 2024
@dwrensha dwrensha added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 21, 2024
@RemyDegenne
Copy link
Contributor

Looks good, thanks!
And sorry that it took several weeks since the last review for someone to notice and merge this.
bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 10, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 10, 2024
Uses `Set.not_nonempty_iff_eq_empty` to shorten the proof of `IsPiSystem.comap`.
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 10, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: simplify proof of IsPiSystem.comap [Merged by Bors] - chore: simplify proof of IsPiSystem.comap Apr 10, 2024
@mathlib-bors mathlib-bors bot closed this Apr 10, 2024
@mathlib-bors mathlib-bors bot deleted the is-pi-system-comap branch April 10, 2024 06:01
Louddy pushed a commit that referenced this pull request Apr 15, 2024
Uses `Set.not_nonempty_iff_eq_empty` to shorten the proof of `IsPiSystem.comap`.
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
Uses `Set.not_nonempty_iff_eq_empty` to shorten the proof of `IsPiSystem.comap`.
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
Uses `Set.not_nonempty_iff_eq_empty` to shorten the proof of `IsPiSystem.comap`.
callesonne pushed a commit that referenced this pull request Apr 22, 2024
Uses `Set.not_nonempty_iff_eq_empty` to shorten the proof of `IsPiSystem.comap`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants