[Merged by Bors] - chore: make List.mem_split an alias of List.append_of_mem #11060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @digama0, who suggested that I should make a PR about this. This duplication was found by tryTacticAtEachStep. |
|
I could additionally add a |
dwrensha
added
the
awaiting-review
|
Yeah, I would also deprecate and remove the uses in mathlib |
done |
YaelDillies
reviewed
Mar 23, 2024
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 24, 2024
`List.mem_split` duplicates `List.append_of_mem` from `Std`: https://github.com/leanprover/std4/blob/a756b7d643ae5dcd7bf314e99f8e493e5d81b9ed/Std/Data/List/Lemmas.lean#L94-L96 This PR makes it an alias. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
`List.mem_split` duplicates `List.append_of_mem` from `Std`: https://github.com/leanprover/std4/blob/a756b7d643ae5dcd7bf314e99f8e493e5d81b9ed/Std/Data/List/Lemmas.lean#L94-L96 This PR makes it an alias. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
`List.mem_split` duplicates `List.append_of_mem` from `Std`: https://github.com/leanprover/std4/blob/a756b7d643ae5dcd7bf314e99f8e493e5d81b9ed/Std/Data/List/Lemmas.lean#L94-L96 This PR makes it an alias. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
`List.mem_split` duplicates `List.append_of_mem` from `Std`: https://github.com/leanprover/std4/blob/a756b7d643ae5dcd7bf314e99f8e493e5d81b9ed/Std/Data/List/Lemmas.lean#L94-L96 This PR makes it an alias. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
`List.mem_split` duplicates `List.append_of_mem` from `Std`: https://github.com/leanprover/std4/blob/a756b7d643ae5dcd7bf314e99f8e493e5d81b9ed/Std/Data/List/Lemmas.lean#L94-L96 This PR makes it an alias. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
`List.mem_split` duplicates `List.append_of_mem` from `Std`: https://github.com/leanprover/std4/blob/a756b7d643ae5dcd7bf314e99f8e493e5d81b9ed/Std/Data/List/Lemmas.lean#L94-L96 This PR makes it an alias. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List.mem_splitduplicatesList.append_of_memfromStd:https://github.com/leanprover/std4/blob/a756b7d643ae5dcd7bf314e99f8e493e5d81b9ed/Std/Data/List/Lemmas.lean#L94-L96
This PR makes it an alias.