Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - doc(LinearAlgebra/PiTensorProduct): improve docstring for tprod notation #11063

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - doc(LinearAlgebra/PiTensorProduct): improve docstring for tprod notation #11063

wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Member

Also remove a TODO by @kmill; tprod r fun i => f i delaborates correctly now. tprod R f does not use notation, but this is no different to the behavior of Finset.sum s f.

Open in Gitpod

@eric-wieser eric-wieser added documentation Improvements or additions to documentation awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI labels Feb 28, 2024
riccardobrasca
riccardobrasca approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 29, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 29, 2024
@eric-wieser
doc(LinearAlgebra/PiTensorProduct): improve docstring for tprod notat…
0aaf3be 
…ion (#11063)

Also remove a TODO by @kmill; `tprod r fun i => f i` delaborates correctly now. `tprod R f` does not use notation, but this is no different to the behavior of `Finset.sum s f`.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 29, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title doc(LinearAlgebra/PiTensorProduct): improve docstring for tprod notation [Merged by Bors] - doc(LinearAlgebra/PiTensorProduct): improve docstring for tprod notation Feb 29, 2024
@mathlib-bors mathlib-bors bot closed this Feb 29, 2024
@mathlib-bors mathlib-bors bot deleted the eric-wieser/tprod-notation branch February 29, 2024 13:36
riccardobrasca pushed a commit that referenced this pull request Mar 1, 2024
@eric-wieser @riccardobrasca
doc(LinearAlgebra/PiTensorProduct): improve docstring for tprod notat…
85b3a2a 
…ion (#11063)

Also remove a TODO by @kmill; `tprod r fun i => f i` delaborates correctly now. `tprod R f` does not use notation, but this is no different to the behavior of `Finset.sum s f`.
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
@eric-wieser @kbuzzard
doc(LinearAlgebra/PiTensorProduct): improve docstring for tprod notat…
4b263ba 
…ion (#11063)

Also remove a TODO by @kmill; `tprod r fun i => f i` delaborates correctly now. `tprod R f` does not use notation, but this is no different to the behavior of `Finset.sum s f`.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@eric-wieser @dagurtomas
doc(LinearAlgebra/PiTensorProduct): improve docstring for tprod notat…
0cdcf59 
…ion (#11063)

Also remove a TODO by @kmill; `tprod r fun i => f i` delaborates correctly now. `tprod R f` does not use notation, but this is no different to the behavior of `Finset.sum s f`.
utensil pushed a commit that referenced this pull request Mar 26, 2024
@eric-wieser @utensil
doc(LinearAlgebra/PiTensorProduct): improve docstring for tprod notat…
7103e00 
…ion (#11063)

Also remove a TODO by @kmill; `tprod r fun i => f i` delaborates correctly now. `tprod R f` does not use notation, but this is no different to the behavior of `Finset.sum s f`.
Louddy pushed a commit that referenced this pull request Apr 15, 2024
@eric-wieser @Louddy
doc(LinearAlgebra/PiTensorProduct): improve docstring for tprod notat…
fc0e2ff 
…ion (#11063)

Also remove a TODO by @kmill; `tprod r fun i => f i` delaborates correctly now. `tprod R f` does not use notation, but this is no different to the behavior of `Finset.sum s f`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riccardobrasca riccardobrasca riccardobrasca approved these changes

@kmill kmill Awaiting requested review from kmill

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eric-wieser @riccardobrasca @leanprover-community-mathlib4-bot