[Merged by Bors] - feat(RingTheory/UniqueFactorizationDomain): add WfDvdMonoid.max_power_factor['] and multiplicity.finite_of_not_isUnit
#11066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acmepjz
added
awaiting-review
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by alreadydone. |
leanprover-community-mathlib4-bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
…r_factor[']` and `multiplicity.finite_of_not_isUnit` (#11066) - makes `UniqueFactorizationMonoid.max_power_factor` obsolete - makes the proof of `multiplicity.finite_prime_left` trivial - relax the condition of `exists_reduced_fraction'` Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
WfDvdMonoid.max_power_factor['] and multiplicity.finite_of_not_isUnitWfDvdMonoid.max_power_factor['] and multiplicity.finite_of_not_isUnit
riccardobrasca
pushed a commit
that referenced
this pull request
Mar 1, 2024
…r_factor[']` and `multiplicity.finite_of_not_isUnit` (#11066) - makes `UniqueFactorizationMonoid.max_power_factor` obsolete - makes the proof of `multiplicity.finite_prime_left` trivial - relax the condition of `exists_reduced_fraction'` Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
kbuzzard
pushed a commit
that referenced
this pull request
Mar 12, 2024
…r_factor[']` and `multiplicity.finite_of_not_isUnit` (#11066) - makes `UniqueFactorizationMonoid.max_power_factor` obsolete - makes the proof of `multiplicity.finite_prime_left` trivial - relax the condition of `exists_reduced_fraction'` Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
…r_factor[']` and `multiplicity.finite_of_not_isUnit` (#11066) - makes `UniqueFactorizationMonoid.max_power_factor` obsolete - makes the proof of `multiplicity.finite_prime_left` trivial - relax the condition of `exists_reduced_fraction'` Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
…r_factor[']` and `multiplicity.finite_of_not_isUnit` (#11066) - makes `UniqueFactorizationMonoid.max_power_factor` obsolete - makes the proof of `multiplicity.finite_prime_left` trivial - relax the condition of `exists_reduced_fraction'` Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
…r_factor[']` and `multiplicity.finite_of_not_isUnit` (#11066) - makes `UniqueFactorizationMonoid.max_power_factor` obsolete - makes the proof of `multiplicity.finite_prime_left` trivial - relax the condition of `exists_reduced_fraction'` Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UniqueFactorizationMonoid.max_power_factorobsoletemultiplicity.finite_prime_lefttrivialexists_reduced_fraction'Co-authored-by: Junyan Xu junyanxu.math@gmail.com
Original post: #10404 (comment)