Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(InfiniteSum/NatInt): lemmas on sums over ℤ #11069

Closed
wants to merge 14 commits into from

Conversation

loefflerd
Copy link
Collaborator

@loefflerd loefflerd commented Feb 29, 2024

This PR combines several results involving topological sums over . These results are used in #10011 (Hurwitz zeta functions) where sums over feature heavily.

  • Fill in tsum and Summable variants for lemmas proved for HasSum

  • Rename some lemmas (with deprecated aliases) to impose a consistent naming scheme

  • Generalise several lemmas to allow the target space to be a topological monoid rather than a group.

  • Speed up some slow proofs (the old summable_int_of_summable_nat took about 10s to compile on my machine, its replacement Summable.of_nat_of_neg is 1000 times faster)


Open in Gitpod

@loefflerd loefflerd changed the title Dl nat int sums feat(InfiniteSum/NatInt): lemmas on sums over ℤ Feb 29, 2024
@Ruben-VandeVelde
Copy link
Collaborator

When you want a review, please add the awaiting-review label

@loefflerd loefflerd added WIP Work in progress awaiting-CI and removed WIP Work in progress labels Mar 3, 2024
@loefflerd loefflerd added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Mar 4, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 7, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 9, 2024
@loefflerd loefflerd requested a review from grunweg March 9, 2024 17:02
Copy link
Collaborator

@MichaelStollBayreuth MichaelStollBayreuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think some topology people should also look at this.

@loefflerd loefflerd added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Mar 10, 2024
Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Mathlib/Topology/Algebra/InfiniteSum/NatInt.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Algebra/InfiniteSum/NatInt.lean Outdated Show resolved Hide resolved
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 15, 2024
@loefflerd loefflerd added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 15, 2024
@sgouezel
Copy link
Contributor

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 16, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 16, 2024
This PR combines several results involving topological sums over `ℤ`. These results are used in #10011 (Hurwitz zeta functions) where sums over `ℤ` feature heavily. 

* Fill in `tsum` and `Summable` variants for lemmas proved for `HasSum`

* Rename some lemmas (with deprecated aliases) to impose a consistent naming scheme

* Generalise several lemmas to allow the target space to be a topological monoid rather than a group.

* Speed up some slow proofs (the old `summable_int_of_summable_nat` took about 10s to compile on my machine, its replacement `Summable.of_nat_of_neg` is 1000 times faster)
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 16, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(InfiniteSum/NatInt): lemmas on sums over ℤ [Merged by Bors] - feat(InfiniteSum/NatInt): lemmas on sums over ℤ Mar 16, 2024
@mathlib-bors mathlib-bors bot closed this Mar 16, 2024
@mathlib-bors mathlib-bors bot deleted the DL_nat_int_sums branch March 16, 2024 16:28
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
This PR combines several results involving topological sums over `ℤ`. These results are used in #10011 (Hurwitz zeta functions) where sums over `ℤ` feature heavily. 

* Fill in `tsum` and `Summable` variants for lemmas proved for `HasSum`

* Rename some lemmas (with deprecated aliases) to impose a consistent naming scheme

* Generalise several lemmas to allow the target space to be a topological monoid rather than a group.

* Speed up some slow proofs (the old `summable_int_of_summable_nat` took about 10s to compile on my machine, its replacement `Summable.of_nat_of_neg` is 1000 times faster)
utensil pushed a commit that referenced this pull request Mar 26, 2024
This PR combines several results involving topological sums over `ℤ`. These results are used in #10011 (Hurwitz zeta functions) where sums over `ℤ` feature heavily. 

* Fill in `tsum` and `Summable` variants for lemmas proved for `HasSum`

* Rename some lemmas (with deprecated aliases) to impose a consistent naming scheme

* Generalise several lemmas to allow the target space to be a topological monoid rather than a group.

* Speed up some slow proofs (the old `summable_int_of_summable_nat` took about 10s to compile on my machine, its replacement `Summable.of_nat_of_neg` is 1000 times faster)
Louddy pushed a commit that referenced this pull request Apr 15, 2024
This PR combines several results involving topological sums over `ℤ`. These results are used in #10011 (Hurwitz zeta functions) where sums over `ℤ` feature heavily. 

* Fill in `tsum` and `Summable` variants for lemmas proved for `HasSum`

* Rename some lemmas (with deprecated aliases) to impose a consistent naming scheme

* Generalise several lemmas to allow the target space to be a topological monoid rather than a group.

* Speed up some slow proofs (the old `summable_int_of_summable_nat` took about 10s to compile on my machine, its replacement `Summable.of_nat_of_neg` is 1000 times faster)
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
This PR combines several results involving topological sums over `ℤ`. These results are used in #10011 (Hurwitz zeta functions) where sums over `ℤ` feature heavily. 

* Fill in `tsum` and `Summable` variants for lemmas proved for `HasSum`

* Rename some lemmas (with deprecated aliases) to impose a consistent naming scheme

* Generalise several lemmas to allow the target space to be a topological monoid rather than a group.

* Speed up some slow proofs (the old `summable_int_of_summable_nat` took about 10s to compile on my machine, its replacement `Summable.of_nat_of_neg` is 1000 times faster)
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
This PR combines several results involving topological sums over `ℤ`. These results are used in #10011 (Hurwitz zeta functions) where sums over `ℤ` feature heavily. 

* Fill in `tsum` and `Summable` variants for lemmas proved for `HasSum`

* Rename some lemmas (with deprecated aliases) to impose a consistent naming scheme

* Generalise several lemmas to allow the target space to be a topological monoid rather than a group.

* Speed up some slow proofs (the old `summable_int_of_summable_nat` took about 10s to compile on my machine, its replacement `Summable.of_nat_of_neg` is 1000 times faster)
callesonne pushed a commit that referenced this pull request Apr 22, 2024
This PR combines several results involving topological sums over `ℤ`. These results are used in #10011 (Hurwitz zeta functions) where sums over `ℤ` feature heavily. 

* Fill in `tsum` and `Summable` variants for lemmas proved for `HasSum`

* Rename some lemmas (with deprecated aliases) to impose a consistent naming scheme

* Generalise several lemmas to allow the target space to be a topological monoid rather than a group.

* Speed up some slow proofs (the old `summable_int_of_summable_nat` took about 10s to compile on my machine, its replacement `Summable.of_nat_of_neg` is 1000 times faster)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants