Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor: simplify vector span proof in AffineSubspace #11074

Closed
wants to merge 1 commit into from

Conversation

dwrensha
Copy link
Member

Replaces a 4-line subproof in vsub_mem_vectorSpan_of_mem_spanPoints_of_mem_spanPoints with a simple application of Submodule.sub_mem.


Open in Gitpod

@dwrensha
Copy link
Member Author

dwrensha commented Feb 29, 2024

This simplification was found via tryTacticAtEachStep.

@dwrensha dwrensha added the awaiting-review The author would like community review of the PR label Feb 29, 2024
Copy link
Collaborator

@mo271 mo271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 1, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 1, 2024
Replaces a 4-line subproof in `vsub_mem_vectorSpan_of_mem_spanPoints_of_mem_spanPoints` with a simple application of `Submodule.sub_mem`.
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 1, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Mar 1, 2024
Replaces a 4-line subproof in `vsub_mem_vectorSpan_of_mem_spanPoints_of_mem_spanPoints` with a simple application of `Submodule.sub_mem`.
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 1, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor: simplify vector span proof in AffineSubspace [Merged by Bors] - refactor: simplify vector span proof in AffineSubspace Mar 1, 2024
@mathlib-bors mathlib-bors bot closed this Mar 1, 2024
@mathlib-bors mathlib-bors bot deleted the tryTacticAtEachStep-affine-subspace branch March 1, 2024 17:47
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
Replaces a 4-line subproof in `vsub_mem_vectorSpan_of_mem_spanPoints_of_mem_spanPoints` with a simple application of `Submodule.sub_mem`.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
Replaces a 4-line subproof in `vsub_mem_vectorSpan_of_mem_spanPoints_of_mem_spanPoints` with a simple application of `Submodule.sub_mem`.
utensil pushed a commit that referenced this pull request Mar 26, 2024
Replaces a 4-line subproof in `vsub_mem_vectorSpan_of_mem_spanPoints_of_mem_spanPoints` with a simple application of `Submodule.sub_mem`.
Louddy pushed a commit that referenced this pull request Apr 15, 2024
Replaces a 4-line subproof in `vsub_mem_vectorSpan_of_mem_spanPoints_of_mem_spanPoints` with a simple application of `Submodule.sub_mem`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants