Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Option {b // b ≠ a} ≃ α #11095

Closed
wants to merge 9 commits into from

Conversation

BoltonBailey
Copy link
Collaborator

@BoltonBailey BoltonBailey commented Mar 1, 2024

Extract from partialFunEquivPointed the equivalence between any type with a distinguished element and an Option type.

Co-authored-by: @YaelDillies yael.dillies@gmail.com
Co-authored-by: @fpvandoorn fpvdoorn@gmail.com


Open in Gitpod

@BoltonBailey
Copy link
Collaborator Author

See discussion here.

@BoltonBailey BoltonBailey added the awaiting-review The author would like community review of the PR label Mar 2, 2024
@fpvandoorn
Copy link
Member

LGTM

@BoltonBailey, are you also happy with these changes from @YaelDillies?

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Mar 4, 2024

✌️ BoltonBailey can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Mar 4, 2024
@YaelDillies YaelDillies changed the title feat: Equiv.toOption feat: Option {b // b ≠ a} ≃ α Mar 4, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 4, 2024
@BoltonBailey
Copy link
Collaborator Author

Yeah seems great! Thanks @YaelDillies!

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 4, 2024
@BoltonBailey
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Mar 4, 2024
Extract from `partialFunEquivPointed` the equivalence between any type with a distinguished element and an Option type.

Co-authored-by: @YaelDillies <yael.dillies@gmail.com>
Co-authored-by: @fpvandoorn <fpvdoorn@gmail.com>



Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 4, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Option {b // b ≠ a} ≃ α [Merged by Bors] - feat: Option {b // b ≠ a} ≃ α Mar 4, 2024
@mathlib-bors mathlib-bors bot closed this Mar 4, 2024
@mathlib-bors mathlib-bors bot deleted the BoltonBailey/equiv-toOption branch March 4, 2024 21:27
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
Extract from `partialFunEquivPointed` the equivalence between any type with a distinguished element and an Option type.

Co-authored-by: @YaelDillies <yael.dillies@gmail.com>
Co-authored-by: @fpvandoorn <fpvdoorn@gmail.com>



Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
Extract from `partialFunEquivPointed` the equivalence between any type with a distinguished element and an Option type.

Co-authored-by: @YaelDillies <yael.dillies@gmail.com>
Co-authored-by: @fpvandoorn <fpvdoorn@gmail.com>



Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
utensil pushed a commit that referenced this pull request Mar 26, 2024
Extract from `partialFunEquivPointed` the equivalence between any type with a distinguished element and an Option type.

Co-authored-by: @YaelDillies <yael.dillies@gmail.com>
Co-authored-by: @fpvandoorn <fpvdoorn@gmail.com>



Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Louddy pushed a commit that referenced this pull request Apr 15, 2024
Extract from `partialFunEquivPointed` the equivalence between any type with a distinguished element and an Option type.

Co-authored-by: @YaelDillies <yael.dillies@gmail.com>
Co-authored-by: @fpvandoorn <fpvdoorn@gmail.com>



Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants