Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: continuity of the parametric set integral #11108

Closed
wants to merge 33 commits into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Mar 2, 2024

@grunweg grunweg added awaiting-review The author would like community review of the PR t-analysis Analysis (normed *, calculus) t-measure-probability Measure theory / Probability theory labels Mar 2, 2024
@loefflerd
Copy link
Collaborator

Could you please extract a separate mini-PR removing the style exceptions for already-fixed overlong files? (I think two of these are my fault, sorry!)

@loefflerd
Copy link
Collaborator

On the topic of overlong files: we definitely don't want to add new style exceptions if we can help it. I wonder if it might make sense to have a new file called something like DominatedConvergence.lean, which could contain all the material currently in Bochner.lean that relies on dominated convergence, together with the new lemmas about set integrals from this PR. That would avoid making SetIntegral overlong, and would also be a step in the right direction for Bochner.lean.

@grunweg
Copy link
Collaborator Author

grunweg commented Mar 3, 2024

@loefflerd Filed #11137 for the style exceptions.

@grunweg grunweg added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 6, 2024
@loefflerd
Copy link
Collaborator

I just realised that I had misunderstood: I thought continuousOn_integral_bilinear_of_locally_integrable_of_compact_support had been added by you, but I see now this was incorrect, it was Sebastian Gouëzel in #8247. So it is clearly irrelevant to the present PR.

@loefflerd
Copy link
Collaborator

loefflerd commented Mar 6, 2024

I think brutally enforcing 𝕜 = ℝ in continuousOn_integral_bilinear_of_locally_integrable_of_compact_support is probably a very bad idea, because the case of complex coefficients is probably needed too. Let's just ignore it and not go looking for trouble 😄

@loefflerd
Copy link
Collaborator

This looks good to me.

(Note to maintainers: the issue discussed above about two NormedSpace declarations in continuousOn_integral_bilinear_of_locally_integrable_of_compact_support has been queried with Sebastian on zulip, and he says it's intentional; but in any case it is orthogonal to the changes made in this PR.)

maintainer merge

Copy link

github-actions bot commented Mar 7, 2024

🚀 Pull request has been placed on the maintainer queue by loefflerd.

@grunweg
Copy link
Collaborator Author

grunweg commented Mar 7, 2024

Thank you for the thorough review!

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 8, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 8, 2024
From the sphere eversion project.

In passing, we rename variables in one more lemma and use fun_prop in a tiny way.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Mar 8, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: continuity of the parametric set integral [Merged by Bors] - feat: continuity of the parametric set integral Mar 8, 2024
@mathlib-bors mathlib-bors bot closed this Mar 8, 2024
@mathlib-bors mathlib-bors bot deleted the MR-sphere-eversion-parametric-integral2 branch March 8, 2024 09:46
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
…one file (#11139)

[Suggested](#11108 (comment)) by @loefflerd.
Only code motion (and cosmetic adaptions, such as minimising import and open statements).

Pre-requisite for #11108 and (morally) #11110.
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
See the individual commit messages for details.

Extracted from #11108.
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
From the sphere eversion project.

In passing, we rename variables in one more lemma and use fun_prop in a tiny way.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
…one file (#11139)

[Suggested](#11108 (comment)) by @loefflerd.
Only code motion (and cosmetic adaptions, such as minimising import and open statements).

Pre-requisite for #11108 and (morally) #11110.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
See the individual commit messages for details.

Extracted from #11108.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
From the sphere eversion project.

In passing, we rename variables in one more lemma and use fun_prop in a tiny way.
utensil pushed a commit that referenced this pull request Mar 26, 2024
…one file (#11139)

[Suggested](#11108 (comment)) by @loefflerd.
Only code motion (and cosmetic adaptions, such as minimising import and open statements).

Pre-requisite for #11108 and (morally) #11110.
utensil pushed a commit that referenced this pull request Mar 26, 2024
See the individual commit messages for details.

Extracted from #11108.
utensil pushed a commit that referenced this pull request Mar 26, 2024
From the sphere eversion project.

In passing, we rename variables in one more lemma and use fun_prop in a tiny way.
Louddy pushed a commit that referenced this pull request Apr 15, 2024
…one file (#11139)

[Suggested](#11108 (comment)) by @loefflerd.
Only code motion (and cosmetic adaptions, such as minimising import and open statements).

Pre-requisite for #11108 and (morally) #11110.
Louddy pushed a commit that referenced this pull request Apr 15, 2024
See the individual commit messages for details.

Extracted from #11108.
Louddy pushed a commit that referenced this pull request Apr 15, 2024
From the sphere eversion project.

In passing, we rename variables in one more lemma and use fun_prop in a tiny way.
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
From the sphere eversion project.

In passing, we rename variables in one more lemma and use fun_prop in a tiny way.
callesonne pushed a commit that referenced this pull request Apr 22, 2024
From the sphere eversion project.

In passing, we rename variables in one more lemma and use fun_prop in a tiny way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus) t-measure-probability Measure theory / Probability theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants