-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: continuity of the parametric set integral #11108
Conversation
And copy one necessary variable into the other sections.
This changes the order of typeclass arguments; not tried to build all of mathlib yet.
Could you please extract a separate mini-PR removing the style exceptions for already-fixed overlong files? (I think two of these are my fault, sorry!) |
On the topic of overlong files: we definitely don't want to add new style exceptions if we can help it. I wonder if it might make sense to have a new file called something like |
@loefflerd Filed #11137 for the style exceptions. |
I just realised that I had misunderstood: I thought |
I think brutally enforcing |
This looks good to me. (Note to maintainers: the issue discussed above about two maintainer merge |
🚀 Pull request has been placed on the maintainer queue by loefflerd. |
Thank you for the thorough review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
From the sphere eversion project. In passing, we rename variables in one more lemma and use fun_prop in a tiny way.
Pull request successfully merged into master. Build succeeded: |
…one file (#11139) [Suggested](#11108 (comment)) by @loefflerd. Only code motion (and cosmetic adaptions, such as minimising import and open statements). Pre-requisite for #11108 and (morally) #11110.
See the individual commit messages for details. Extracted from #11108.
From the sphere eversion project. In passing, we rename variables in one more lemma and use fun_prop in a tiny way.
…one file (#11139) [Suggested](#11108 (comment)) by @loefflerd. Only code motion (and cosmetic adaptions, such as minimising import and open statements). Pre-requisite for #11108 and (morally) #11110.
See the individual commit messages for details. Extracted from #11108.
From the sphere eversion project. In passing, we rename variables in one more lemma and use fun_prop in a tiny way.
…one file (#11139) [Suggested](#11108 (comment)) by @loefflerd. Only code motion (and cosmetic adaptions, such as minimising import and open statements). Pre-requisite for #11108 and (morally) #11110.
See the individual commit messages for details. Extracted from #11108.
From the sphere eversion project. In passing, we rename variables in one more lemma and use fun_prop in a tiny way.
…one file (#11139) [Suggested](#11108 (comment)) by @loefflerd. Only code motion (and cosmetic adaptions, such as minimising import and open statements). Pre-requisite for #11108 and (morally) #11110.
See the individual commit messages for details. Extracted from #11108.
From the sphere eversion project. In passing, we rename variables in one more lemma and use fun_prop in a tiny way.
From the sphere eversion project. In passing, we rename variables in one more lemma and use fun_prop in a tiny way.
From the sphere eversion project. In passing, we rename variables in one more lemma and use fun_prop in a tiny way.
From the sphere eversion project.
In passing, we rename variables in one more lemma and use fun_prop in a tiny way.