Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor: deprecate duplicated RespectsIso theorem #11115

Closed
wants to merge 1 commit into from

Conversation

dwrensha
Copy link
Member

@dwrensha dwrensha commented Mar 2, 2024

Deprecates RespectsIso.ofRestrict_morphismRestrict_iff_of_isAffine in favor of the older RespectsIso.basicOpen_iff_localization, and removes a local notation that is only used in the removed proof.


Open in Gitpod

@dwrensha
Copy link
Member Author

dwrensha commented Mar 2, 2024

cc @erdOne, who added RespectsIso.ofRestrict_morphismRestrict_iff_of_isAffine in #7749.

@dwrensha
Copy link
Member Author

dwrensha commented Mar 2, 2024

Found by tryAtEachStep.

@dwrensha dwrensha added the awaiting-review The author would like community review of the PR label Mar 2, 2024
@fpvandoorn
Copy link
Member

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Mar 2, 2024

✌️ dwrensha can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Mar 2, 2024
@dwrensha
Copy link
Member Author

dwrensha commented Mar 2, 2024

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Mar 2, 2024
Deprecates `RespectsIso.ofRestrict_morphismRestrict_iff_of_isAffine` in favor of the older `RespectsIso.basicOpen_iff_localization`, and removes a local notation that is only used in the removed proof.
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 2, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor: deprecate duplicated RespectsIso theorem [Merged by Bors] - refactor: deprecate duplicated RespectsIso theorem Mar 2, 2024
@mathlib-bors mathlib-bors bot closed this Mar 2, 2024
@mathlib-bors mathlib-bors bot deleted the basicOpen_iff_localization-alias branch March 2, 2024 21:36
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
Deprecates `RespectsIso.ofRestrict_morphismRestrict_iff_of_isAffine` in favor of the older `RespectsIso.basicOpen_iff_localization`, and removes a local notation that is only used in the removed proof.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
Deprecates `RespectsIso.ofRestrict_morphismRestrict_iff_of_isAffine` in favor of the older `RespectsIso.basicOpen_iff_localization`, and removes a local notation that is only used in the removed proof.
utensil pushed a commit that referenced this pull request Mar 26, 2024
Deprecates `RespectsIso.ofRestrict_morphismRestrict_iff_of_isAffine` in favor of the older `RespectsIso.basicOpen_iff_localization`, and removes a local notation that is only used in the removed proof.
Louddy pushed a commit that referenced this pull request Apr 15, 2024
Deprecates `RespectsIso.ofRestrict_morphismRestrict_iff_of_isAffine` in favor of the older `RespectsIso.basicOpen_iff_localization`, and removes a local notation that is only used in the removed proof.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants